Conversation
DanNixon
force-pushed
the
upgrade-rust-version
branch
from
cf310db to
00c6467
Compare
Merged
Modularius
requested changes
Jan 17, 2025
Contributor
Modularius
left a comment
Modularius
left a comment
There was a problem hiding this comment.
In the main Cargo.toml, line 51 should be updated to
taos = { version = "0.10.27", default-features = false, features = ["ws"] }
as default_features is deprecated.
DanNixon
force-pushed
the
upgrade-rust-version
branch
from
00c6467 to
136fed7
Compare
DanNixon
force-pushed
the
upgrade-rust-version
branch
from
136fed7 to
a91dae4
Compare
Modularius
approved these changes
Jan 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Moves to Rust 1.84.
Something higher than 1.80 was required to move to the maintained fork of
hdf5.This also addresses a few new warnings generated.
Instruction for review/testing