Merged
Conversation
DanNixon
requested changes
Feb 4, 2025
Member
DanNixon
left a comment
There was a problem hiding this comment.
Looks good.
A couple of other things that might as well be done now:
- Could the term "run file" be revisited. This does not really seem to describe the thing it actually refers to (a separate file describing a run vs. a collection of run metadata).
- Could
crate::hdf5_file::run_file_componentsbe moved tocrate::hdf5_file::run_file::components?
Contributor
Author
|
The This PR is the first in a couple I've got planned which will, among other things make the naming conventions more logical. It's probably okay to leave |
DanNixon
requested changes
Feb 10, 2025
DanNixon
approved these changes
Feb 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
thiserrorstyle error handling removing over-reliance onanyhow. The code now conforms to ADR 7. Standardise error handling.hdf5::{Group, Dataset, Attribute}inhdf5_writer.rs.Locationfield in non-hdf5 related errors.timeDataset with a "units" and "start" attribute, where "start" denotes the RFC3999 date/time to which the time value is relative to.Instruction for review/testing