Add discarded flag to digitiser aggregator spans#309
Merged
DanNixon merged 7 commits intoISISNeutronMuon:mainfrom Feb 4, 2025
Merged
Conversation
DanNixon
requested changes
Feb 4, 2025
DanNixon
approved these changes
Feb 4, 2025
DanNixon
requested changes
Feb 4, 2025
DanNixon
approved these changes
Feb 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Minor code change to allow OpenTelemetry to record when a digitiser message is discarded by the aggregator for being irreparably out of chronological order.
Instruction for review/testing
General code check.
Has been tested with simulated and HiFi data.