Skip to content

Refactor nexus writer#331

Merged
DanNixon merged 132 commits intoISISNeutronMuon:mainfrom
Modularius:Refactor-Nexus-Writer
Apr 15, 2025
Merged

Refactor nexus writer#331
DanNixon merged 132 commits intoISISNeutronMuon:mainfrom
Modularius:Refactor-Nexus-Writer

Conversation

@Modularius
Copy link
Contributor

@Modularius Modularius commented Apr 9, 2025

Summary of changes

  • The structure of the nexus file is reflected in the directory structure of the nexus_structure module.
  • Made error handling more robust
  • Added Readme.rm in docs giving summary of source file structure.
  • Calls hdf5 flush on each message rathe rather close and reopen
  • Consolidates some tracing data into a single span for each message
  • Added some docstrings

Closes Refactor Code in Nexus Writer to Follow Structure of Nexus Format, nexus-writer: address unpopulated values, and nexus-wrter: HDF5 version identifier is hardcoded.

Instruction for review/testing

General Code Review
Tested on Simulated Data and HiFi

@Modularius Modularius requested a review from DanNixon April 9, 2025 17:27
Copy link
Member

@DanNixon DanNixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Modularius Modularius requested a review from DanNixon April 14, 2025 12:20
@DanNixon DanNixon merged commit 9eaf58a into ISISNeutronMuon:main Apr 15, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor Code in Nexus Writer to Follow Structure of Nexus Format

2 participants