Refactor nexus writer#331
Merged
DanNixon merged 132 commits intoISISNeutronMuon:mainfrom Apr 15, 2025
Merged
Conversation
DanNixon
requested changes
Apr 11, 2025
Member
DanNixon
left a comment
There was a problem hiding this comment.
From an initial look.
There are also a lot of violations of these style rules throughout:
DanNixon
approved these changes
Apr 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
nexus_structuremodule.Readme.rmindocsgiving summary of source file structure.Closes Refactor Code in Nexus Writer to Follow Structure of Nexus Format, nexus-writer: address unpopulated values, and nexus-wrter: HDF5 version identifier is hardcoded.
Instruction for review/testing
General Code Review
Tested on Simulated Data and HiFi