Pause sample env topic between runs#336
Merged
DanNixon merged 10 commits intoISISNeutronMuon:mainfrom May 3, 2025
Merged
Conversation
…e injected to nexus_engine more easily
DanNixon
requested changes
Apr 29, 2025
DanNixon
requested changes
May 2, 2025
DanNixon
approved these changes
May 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
create_default_consumerin common crate to maketopics_to_subscribeparameter optional. Also pushes error handling responsability to the caller.NexusEnginedependencies into a trait to aid future extension.KafkaTopicSubscribertoNexusEnginewhich allowsNexusEngineto switch between two topic subscriber modes: "Full" (which subscribes to all topics) and "Continuous" (which subscribes to all but SampleEnvironmentLogs and Alarms).Pending further info from Peter, the RunLog topic could also be removed from the "Continuous" mode if required, at the moment it is not removed.
Closes Record sample env logs since end of last run in current run.
Instruction for review/testing
General Code Review.
Tested on Simulated Data.