Skip to content

Refactor trace to events to prevent redundant calculations#466

Merged
DanNixon merged 5 commits intoISISNeutronMuon:mainfrom
Modularius:Improve-2-Trace-to-events
Mar 16, 2026
Merged

Refactor trace to events to prevent redundant calculations#466
DanNixon merged 5 commits intoISISNeutronMuon:mainfrom
Modularius:Improve-2-Trace-to-events

Conversation

@Modularius
Copy link
Contributor

Summary of changes

Refactors trace-to-events to allow particular settings and objects used in the algorithms to be persisted across digitiser message.

  • This prevents some unnecessary memory allocations.
  • Avoids redundant recalculations (e.g. recomputing the gaussian kernel each time).
  • Reserves memory and objects on a per-channel basis, so that channel traces can be processed in parallel without race conditions.
  • Does not persist trace data, ensuring each channel trace is still independent.
  • Improves consistency in the times taken to process messages.

Note that, optimisations to the Smoothing Algorithm will be addressed in a future PR.

Instruction for review/testing

General code review.
Has been tested with simulated data.

@Modularius Modularius requested a review from DanNixon March 13, 2026 13:15
@Modularius Modularius changed the title Improve 2 trace to events Refactor trace to events to prevent redundant calculations Mar 13, 2026
@Modularius Modularius requested a review from DanNixon March 13, 2026 19:07
@DanNixon DanNixon merged commit c4c7e93 into ISISNeutronMuon:main Mar 16, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants