Refactor trace to events to prevent redundant calculations#466
Merged
DanNixon merged 5 commits intoISISNeutronMuon:mainfrom Mar 16, 2026
Merged
Refactor trace to events to prevent redundant calculations#466DanNixon merged 5 commits intoISISNeutronMuon:mainfrom
DanNixon merged 5 commits intoISISNeutronMuon:mainfrom
Conversation
DanNixon
reviewed
Mar 13, 2026
DanNixon
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Refactors
trace-to-eventsto allow particular settings and objects used in the algorithms to be persisted across digitiser message.Note that, optimisations to the Smoothing Algorithm will be addressed in a future PR.
Instruction for review/testing
General code review.
Has been tested with simulated data.