issmversion.py: Fix so docstring is correct and prints version#166
Merged
Conversation
Collaborator
|
Documentation has been updated as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling
issmversion()doesn't print anything even though docstring implies it will. This fixes that. This is still a bit confusing if running this in notebooks with persistent sessions, because the 2nd time it's imported nothing is printed and the previous version ouptut is removed, implying your environment is not working correctly. A better implementation might not print anything when imported, and documentation could be updated fromto
Which would behave the same if run 1x or 2x in a persistent session.