Skip to content

CHG: Fix calculating basal stress using "friction.m" class. Synchronize Matlab >Python. #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 6, 2025
Merged

CHG: Fix calculating basal stress using "friction.m" class. Synchronize Matlab >Python. #74

merged 2 commits into from
Aug 6, 2025

Conversation

@inwoo-park
Copy link
Contributor

@inwoo-park inwoo-park commented Aug 6, 2025

  • Updated regarding ISSM issue #73.
  • The effective pressure calculation for basal stress differed from src/c/classes/Loads/Friction.cpp depending on the md.friction.coupling method.
  • Modified to ensure the effective pressure is calculated based on the friction law defined in the friction.m class.
  • Synchronized Matlab > Python.

@inwoo-park inwoo-park mentioned this pull request Aug 6, 2025
Closed
@MathieuMorlighem MathieuMorlighem merged commit 44bd945 into ISSMteam:main Aug 6, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@inwoo-park @MathieuMorlighem