Delete of unnecesary Autowired - DocumentController #841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ivilarop
approved these changes
Apr 24, 2025
paumaneja
reviewed
Apr 29, 2025
There was a problem hiding this comment.
I noticed that env (lines 29-30) is still being injected using @Autowired, while the other dependencies (openApiConfig and documentService) are injected via constructor.
Since the goal of the PR is to remove @Autowired, I was wondering if there's any particular reason why env was kept this way — maybe something I'm missing?
Also, would using @requiredargsconstructor with all three fields marked as final be a viable alternative here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using constructor injection, Spring automatically injects the dependencies without requiring the @Autowired annotation. So We can safely remove it from the constructor.