Skip to content

#87 πŸ› fix: ν•™μŠ΅ 도메인 기사 검색(λŒ€μ†Œλ¬Έμž λ¬΄μ‹œ)#88

Merged
kkshyun merged 1 commit intodevelopfrom
refactor/#87-learning-search
Feb 18, 2026
Merged

#87 πŸ› fix: ν•™μŠ΅ 도메인 기사 검색(λŒ€μ†Œλ¬Έμž λ¬΄μ‹œ)#88
kkshyun merged 1 commit intodevelopfrom
refactor/#87-learning-search

Conversation

@kkshyun
Copy link
Copy Markdown
Member

@kkshyun kkshyun commented Feb 18, 2026

πŸ“ PR νƒ€μž… (ν•˜λ‚˜ 이상 선택)

  • κΈ°λŠ₯ μΆ”κ°€
  • 버그 μˆ˜μ •
  • μ˜μ‘΄μ„±, ν™˜κ²½ λ³€μˆ˜, λΉŒλ“œ κ΄€λ ¨ μ½”λ“œ μ—…λ°μ΄νŠΈ
  • 기타 μ‚¬μ†Œν•œ μˆ˜μ •

❗️ κ΄€λ ¨ 이슈 링크

Close #87

πŸ“Œ κ°œμš”

ν•™μŠ΅ ν™”λ©΄ 기사 검색이 λŒ€μ†Œλ¬Έμžμ— 따라 검색 κ²°κ³Όκ°€ λ‹¬λΌμ§€λŠ” 문제 생김

πŸ” λ³€κ²½ 사항

검색 ν‚€μ›Œλ“œ(μž…λ ₯κ°’)λ₯Ό μ •κ·œν™”ν•˜μ—¬ λŒ€μ†Œλ¬Έμžμ™€ λ¬΄κ΄€ν•˜κ²Œ 동일 κ²°κ³Όκ°€ λ‚˜μ˜€λ„λ‘ μˆ˜μ •

πŸ“Έ μŠ€ν¬λ¦°μƒ·

πŸ‘€ 기타 더 이야기해볼 점

βœ… 체크 리슀트

  • PR ν…œν”Œλ¦Ώμ— λ§žμΆ”μ–΄ μž‘μ„±ν–ˆμ–΄μš”.
  • λ³€κ²½ λ‚΄μš©μ— λŒ€ν•œ ν…ŒμŠ€νŠΈλ₯Ό μ§„ν–‰ν–ˆμ–΄μš”.
  • ν”„λ‘œκ·Έλž¨μ΄ μ •μƒμ μœΌλ‘œ λ™μž‘ν•΄μš”.
  • PR에 μ μ ˆν•œ 라벨을 μ„ νƒν–ˆμ–΄μš”.
  • λΆˆν•„μš”ν•œ μ½”λ“œλŠ” μ‚­μ œν–ˆμ–΄μš”.

Summary by CodeRabbit

버그 μˆ˜μ •

  • 검색 κΈ°λŠ₯이 λŒ€μ†Œλ¬Έμžλ₯Ό κ΅¬λΆ„ν•˜μ§€ μ•Šλ„λ‘ κ°œμ„ λ˜μ—ˆμŠ΅λ‹ˆλ‹€. 제λͺ©, μš©μ–΄ μΉ΄λ“œ, μš”μ•½ 정보 검색 μ‹œ λŒ€μ†Œλ¬Έμž 상관없이 μΌκ΄€λœ 검색 κ²°κ³Όλ₯Ό μ œκ³΅ν•©λ‹ˆλ‹€.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Feb 18, 2026

Caution

Review failed

The pull request is closed.

Walkthrough

검색 κΈ°λŠ₯의 λŒ€μ†Œλ¬Έμž ꡬ뢄 문제λ₯Ό ν•΄κ²°ν•˜κΈ° μœ„ν•΄ QueryDsl 검색 쑰건을 μˆ˜μ •ν–ˆμŠ΅λ‹ˆλ‹€. 제λͺ©, μš©μ–΄ μΉ΄λ“œ ν‘œμ‹œλͺ…, μš”μ•½ λ‚΄μš© κ²€μƒ‰μ—μ„œ case-sensitive 맀칭을 case-insensitive 맀칭으둜 λ³€κ²½ν•˜μ—¬ μ‚¬μš©μž κ²½ν—˜μ„ κ°œμ„ ν–ˆμŠ΅λ‹ˆλ‹€.

Changes

Cohort / File(s) Summary
검색 쑰건 λŒ€μ†Œλ¬Έμž ꡬ뢄 제거
src/main/java/com/finsight/finsight/domain/naver/domain/service/ArticleQueryDslImpl.java
제λͺ©(containsIgnoreCase), μš©μ–΄ μΉ΄λ“œ ν‘œμ‹œλͺ…(containsIgnoreCase), μš”μ•½ λ‚΄μš©(containsIgnoreCase)의 3κ³³ 검색 쑰건을 case-insensitive둜 λ³€κ²½ν•˜μ—¬ λŒ€μ†Œλ¬Έμžμ™€ λ¬΄κ΄€ν•˜κ²Œ 검색 κ²°κ³Όλ₯Ό λ°˜ν™˜ν•˜λ„λ‘ μˆ˜μ •

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes


πŸ“‹ 리뷰 μ½”λ©˜νŠΈ

이 변경사항은 맀우 λͺ…ν™•ν•˜κ³  κΈμ •μ μž…λ‹ˆλ‹€. λͺ‡ κ°€μ§€ ν™•μΈν•˜κ³  싢은 뢀뢄이 μžˆμŠ΅λ‹ˆλ‹€:

βœ… 쒋은 점

  • μΌκ΄€λœ μˆ˜μ •: 검색과 κ΄€λ ¨λœ λͺ¨λ“  쑰건을 κ· μΌν•˜κ²Œ λŒ€μ†Œλ¬Έμž λ¬΄μ‹œλ‘œ λ³€κ²½ν–ˆλ„€μš”. λˆ„λ½λœ 뢀뢄이 μ—†μ–΄μ„œ μ’‹μŠ΅λ‹ˆλ‹€.
  • μ΅œμ†Œν•œμ˜ λ³€κ²½: 둜직 κ΅¬μ‘°λŠ” μœ μ§€ν•˜λ©΄μ„œ ν•„μš”ν•œ λΆ€λΆ„λ§Œ μˆ˜μ •ν–ˆμŠ΅λ‹ˆλ‹€.

⚠️ 확인 사항

  1. μ„±λŠ₯ 영ν–₯: containsIgnoreCase()λŠ” λ‚΄λΆ€μ μœΌλ‘œ λŒ€μ†Œλ¬Έμž λ³€ν™˜ μž‘μ—…μ„ μˆ˜ν–‰ν•©λ‹ˆλ‹€. λŒ€λŸ‰μ˜ 데이터λ₯Ό 검색할 λ•ŒλŠ” 인덱슀 ν™œμš©μ΄ μ–΄λ €μšΈ 수 μžˆμœΌλ―€λ‘œ, ν•„μš”μ‹œ λ°μ΄ν„°λ² μ΄μŠ€ 레벨의 collation 섀정을 κ²€ν† ν•˜λ©΄ 더 νš¨μœ¨μ μž…λ‹ˆλ‹€.

  2. λͺ¨λ“  검색 ν•„λ“œ 확인: 이 파일의 λ‹€λ₯Έ 검색 쑰건(예: μž‘μ„±μž, μΉ΄ν…Œκ³ λ¦¬ λ“±)도 λ™μΌν•˜κ²Œ λŒ€μ†Œλ¬Έμž ꡬ뢄이 ν•„μš” μ—†λ‹€λ©΄ ν•¨κ»˜ μˆ˜μ •ν•˜λŠ” 것이 쒋을 것 κ°™μŠ΅λ‹ˆλ‹€.

  3. ν…ŒμŠ€νŠΈ 컀버리지: "검색어 'Python'으둜 'python' ν¬ν•¨λœ κΈ€ μ°ΎκΈ°" 같은 μΌ€μ΄μŠ€κ°€ ν…ŒμŠ€νŠΈλ‘œ 보μž₯되고 μžˆλŠ”μ§€ ν™•μΈν•΄μ£Όμ„Έμš”.

✨ Finishing Touches
  • πŸ“ Generate docstrings
πŸ§ͺ Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch refactor/#87-learning-search

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❀️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kkshyun kkshyun merged commit 6343240 into develop Feb 18, 2026
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant