Merged
Conversation
Contributor
Walkthrough
Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related issuesPossibly related PRs🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In
`@src/main/java/com/ongil/backend/domain/advertisement/service/AdvertisementService.java`:
- Line 28: The hardcoded advertisement entry using
advertisementConverter.toResponse(5L, ...,
"[https://image11.coupangcdn.com/...]") references an external Coupang CDN;
replace that external image URL with a project-hosted CDN/CloudFront URL (or a
local asset path) to avoid hotlinking and stability/licensing issues—update the
argument passed to advertisementConverter.toResponse for the 5L record to point
to the internal CDN path used by other ads.
- Around line 24-28: The image URL arguments in the
advertisementConverter.toResponse calls (e.g., toResponse(1L,...),
toResponse(2L,...), toResponse(3L,...), toResponse(4L,...), toResponse(5L,...))
are wrapped in Markdown link syntax "[url](url)"; replace each image argument
with the raw URL string (remove the surrounding [ and ](...)) so the third
parameter passed to advertisementConverter.toResponse is the plain URL for each
advertisement entry in AdvertisementService.java.
src/main/java/com/ongil/backend/domain/advertisement/service/AdvertisementService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/ongil/backend/domain/advertisement/service/AdvertisementService.java
Outdated
Show resolved
Hide resolved
This was referenced Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔍️ 작업 내용
fix: 홈 화면 배너 목데이터 수정
✨ 상세 설명
🛠️ 추후 리팩토링 및 고도화 계획
📸 스크린샷 (선택)
💬 리뷰 요구사항
Summary by CodeRabbit
릴리즈 노트