Skip to content

fix: 홈 화면 배너 목데이터 수정#131

Merged
neibler merged 2 commits intodevelopfrom
feature/129
Feb 13, 2026
Merged

fix: 홈 화면 배너 목데이터 수정#131
neibler merged 2 commits intodevelopfrom
feature/129

Conversation

@neibler
Copy link
Copy Markdown
Contributor

@neibler neibler commented Feb 13, 2026

🔍️ 작업 내용

  • Closes #
    fix: 홈 화면 배너 목데이터 수정

✨ 상세 설명

🛠️ 추후 리팩토링 및 고도화 계획

📸 스크린샷 (선택)

💬 리뷰 요구사항

Summary by CodeRabbit

릴리즈 노트

  • 새로운 기능
    • 홈페이지 광고 콘텐츠가 전면 업데이트되었습니다. 제목과 부제목이 새로운 프로모션 텍스트로 교체되어 최신 캠페인을 반영합니다.
    • 광고 이미지가 외부 예시 URL에서 S3 기반 이미지 URL로 변경되어 안정적이고 최신의 시각적 자산이 제공됩니다.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Feb 13, 2026

Walkthrough

AdvertisementServicegetHomeAdvertisements 메서드가 반환하는 5개 광고 응답의 텍스트(제목·부제)와 이미지 URL을 교체합니다. 메서드 시그니처·제어 흐름·응답 변환 호출은 그대로 유지되며, 이미지 URL이 example.com에서 S3(또는 CDN) 주소로 바뀌었습니다.

Changes

Cohort / File(s) Summary
Advertisement Mock Data Update
src/main/java/com/ongil/backend/domain/advertisement/service/AdvertisementService.java
getHomeAdvertisements의 5개 광고 항목 페이로드 갱신: 제목·부제 텍스트 변경 및 이미지 URL을 example.com에서 S3/CDN 기반 URL로 교체. 메서드 구조·로직 변경 없음.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related issues

Possibly related PRs

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed PR 제목은 변경사항의 주요 내용을 명확하게 설명하고 있습니다. 홈 화면 배너 목데이터 수정이라는 내용이 실제 변경사항(배너 데이터 업데이트)과 일치합니다.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into develop

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/129

No actionable comments were generated in the recent review. 🎉


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Fix all issues with AI agents
In
`@src/main/java/com/ongil/backend/domain/advertisement/service/AdvertisementService.java`:
- Line 28: The hardcoded advertisement entry using
advertisementConverter.toResponse(5L, ...,
"[https://image11.coupangcdn.com/...]") references an external Coupang CDN;
replace that external image URL with a project-hosted CDN/CloudFront URL (or a
local asset path) to avoid hotlinking and stability/licensing issues—update the
argument passed to advertisementConverter.toResponse for the 5L record to point
to the internal CDN path used by other ads.
- Around line 24-28: The image URL arguments in the
advertisementConverter.toResponse calls (e.g., toResponse(1L,...),
toResponse(2L,...), toResponse(3L,...), toResponse(4L,...), toResponse(5L,...))
are wrapped in Markdown link syntax "[url](url)"; replace each image argument
with the raw URL string (remove the surrounding [ and ](...)) so the third
parameter passed to advertisementConverter.toResponse is the plain URL for each
advertisement entry in AdvertisementService.java.

@neibler neibler merged commit 0999064 into develop Feb 13, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant