Skip to content

[Refactor] OpenAI 클라이언트 공통 호출 레이어 추출 #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marshmallowing merged 2 commits into from
Feb 19, 2026
Merged

[Refactor] OpenAI 클라이언트 공통 호출 레이어 추출 #154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f89f0e2
feat: OpenAI 공통 호출 레이어 추가
Feb 19, 2026
1942ad4
refactor: OpenAiClient로 일원화, 프롬프트 수정
Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
73 changes: 28 additions & 45 deletions src/main/java/com/ongil/backend/domain/product/service/AiMaterialService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,49 +1,37 @@
package com.ongil.backend.domain.product.service;

import java.time.Duration;
import java.util.List;

import org.springframework.beans.factory.annotation.Value;
import org.springframework.stereotype.Service;

import com.ongil.backend.domain.product.dto.response.AiMaterialDescriptionResponse;
import com.theokanning.openai.completion.chat.ChatCompletionRequest;
import com.theokanning.openai.completion.chat.ChatMessage;
import com.theokanning.openai.service.OpenAiService;
import com.ongil.backend.global.openai.OpenAiClient;
import com.ongil.backend.global.openai.OpenAiException;
import com.ongil.backend.global.openai.OpenAiRequest;

import lombok.RequiredArgsConstructor;
import lombok.extern.slf4j.Slf4j;

@Slf4j
@Service
@RequiredArgsConstructor
public class AiMaterialService {

private final OpenAiService openAiService;

public AiMaterialService(@Value("${openai.api-key}") String apiKey) {
this.openAiService = new OpenAiService(apiKey, Duration.ofSeconds(60));
}
private final OpenAiClient openAiClient;

public AiMaterialDescriptionResponse generate(String material) {

try {
String prompt = createPrompt(material);

ChatCompletionRequest request = ChatCompletionRequest.builder()
.model("gpt-3.5-turbo")
.messages(List.of(
new ChatMessage("system", "당신은 의류 소재 전문가입니다. 60대 이상 어르신이 이해하기 쉽게 설명해주세요."),
new ChatMessage("user", prompt)
))
.temperature(0.3)
.maxTokens(1500)
.build();

String response = openAiService.createChatCompletion(request)
.getChoices()
.get(0)
.getMessage()
.getContent();

OpenAiRequest request = OpenAiRequest.of(
"gpt-3.5-turbo",
"당신은 의류 소재 전문가입니다. 60대 이상 어르신이 이해하기 쉽게 설명해주세요.",
createPrompt(material),
0.3
);
String response = openAiClient.call(request);
return parseResponse(response);

} catch (OpenAiException e) {
log.warn("[AiMaterialService] AI 호출 실패, 기본값 반환. 소재: {}", material);
return AiMaterialDescriptionResponse.createDefault();
} catch (Exception e) {
log.warn("[AiMaterialService] 응답 파싱 실패, 기본값 반환. 소재: {}", material);
return AiMaterialDescriptionResponse.createDefault();
}
}
Expand Down Expand Up @@ -86,22 +74,17 @@ private String createPrompt(String material) {
}

private AiMaterialDescriptionResponse parseResponse(String response) {
try {
String[] sections = response.split("\\[장점\\]|\\[단점\\]|\\[세탁방법\\]");

if (sections.length < 4) {
return AiMaterialDescriptionResponse.createDefault();
}
String[] sections = response.split("\\[장점\\]|\\[단점\\]|\\[세탁방법\\]");

return AiMaterialDescriptionResponse.builder()
.advantages(cleanSection(sections[1]))
.disadvantages(cleanSection(sections[2]))
.care(cleanSection(sections[3]))
.build();

} catch (Exception e) {
if (sections.length < 4) {
return AiMaterialDescriptionResponse.createDefault();
}

return AiMaterialDescriptionResponse.builder()
.advantages(cleanSection(sections[1]))
.disadvantages(cleanSection(sections[2]))
.care(cleanSection(sections[3]))
.build();
}

private String cleanSection(String section) {
Expand Down
103 changes: 47 additions & 56 deletions src/main/java/com/ongil/backend/domain/review/service/AiReviewGeneratorService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,79 +1,70 @@
package com.ongil.backend.domain.review.service;

import java.util.Arrays;
import java.util.List;

import org.springframework.stereotype.Service;

import com.ongil.backend.domain.review.dto.request.AiReviewGenerateRequest;
import com.ongil.backend.domain.review.dto.response.AiReviewResponse;
import com.ongil.backend.domain.review.service.prompter.MaterialReviewPrompter;
import com.ongil.backend.domain.review.service.prompter.SizeReviewPrompter;
import com.ongil.backend.domain.review.validator.ReviewValidator;
import com.ongil.backend.global.common.exception.AppException;
import com.ongil.backend.global.common.exception.ErrorCode;
import com.theokanning.openai.completion.chat.ChatCompletionRequest;
import com.theokanning.openai.completion.chat.ChatMessage;
import com.theokanning.openai.completion.chat.ChatMessageRole;
import com.theokanning.openai.service.OpenAiService;
import com.ongil.backend.global.openai.OpenAiClient;
import com.ongil.backend.global.openai.OpenAiException;
import com.ongil.backend.global.openai.OpenAiRequest;

import lombok.RequiredArgsConstructor;
import lombok.extern.slf4j.Slf4j;

import org.springframework.stereotype.Service;

import java.util.Arrays;
import java.util.List;

@Slf4j
@Service
@RequiredArgsConstructor
public class AiReviewGeneratorService {

private final OpenAiService openAiService;
private final SizeReviewPrompter sizePrompter;
private final MaterialReviewPrompter materialPrompter;
private final ReviewValidator reviewValidator;

public AiReviewResponse generateSizeReview(AiReviewGenerateRequest request) {
reviewValidator.validateReviewStepCompletion(request.getSizeAnswer(), request.getFitIssueParts());

String systemPrompt = sizePrompter.getSystemPrompt();
String userMessage = sizePrompter.buildUserMessage(request);

String aiResponse = callOpenAi(systemPrompt, userMessage);
return AiReviewResponse.of(request.getReviewId(), parseAiResponse(aiResponse));
}

public AiReviewResponse generateMaterialReview(AiReviewGenerateRequest request) {
reviewValidator.validateReviewStepCompletion(request.getMaterialAnswer(), request.getMaterialFeatures());

String systemPrompt = materialPrompter.getSystemPrompt();
String userMessage = materialPrompter.buildUserMessage(request);
private final OpenAiClient openAiClient;
private final SizeReviewPrompter sizePrompter;
private final MaterialReviewPrompter materialPrompter;
private final ReviewValidator reviewValidator;

String aiResponse = callOpenAi(systemPrompt, userMessage);
return AiReviewResponse.of(request.getReviewId(), parseAiResponse(aiResponse));
}
public AiReviewResponse generateSizeReview(AiReviewGenerateRequest request) {
reviewValidator.validateReviewStepCompletion(request.getSizeAnswer(), request.getFitIssueParts());

private String callOpenAi(String systemPrompt, String userMessage) {
List<ChatMessage> messages = List.of(
new ChatMessage(ChatMessageRole.SYSTEM.value(), systemPrompt),
new ChatMessage(ChatMessageRole.USER.value(), userMessage)
);
try {
String aiResponse = openAiClient.call(OpenAiRequest.of(
"gpt-4o-mini",
sizePrompter.getSystemPrompt(),
sizePrompter.buildUserMessage(request),
0.7
));
return AiReviewResponse.of(request.getReviewId(), parseAiResponse(aiResponse));
} catch (OpenAiException e) {
throw new AppException(ErrorCode.AI_GENERATION_ERROR);
}
}

ChatCompletionRequest completionRequest = ChatCompletionRequest.builder()
.model("gpt-4o-mini")
.messages(messages)
.temperature(0.7)
.build();
public AiReviewResponse generateMaterialReview(AiReviewGenerateRequest request) {
reviewValidator.validateReviewStepCompletion(request.getMaterialAnswer(), request.getMaterialFeatures());

try {
return openAiService.createChatCompletion(completionRequest)
.getChoices().get(0).getMessage().getContent().trim();
} catch (Exception e) {
log.error("AI 생성 실패: ", e);
throw new AppException(ErrorCode.AI_GENERATION_ERROR);
}
}
try {
String aiResponse = openAiClient.call(OpenAiRequest.of(
"gpt-4o-mini",
materialPrompter.getSystemPrompt(),
materialPrompter.buildUserMessage(request),
0.7
));
return AiReviewResponse.of(request.getReviewId(), parseAiResponse(aiResponse));
} catch (OpenAiException e) {
throw new AppException(ErrorCode.AI_GENERATION_ERROR);
}
}

private List<String> parseAiResponse(String aiResponse) {
return Arrays.stream(aiResponse.split("\\|"))
.map(String::trim)
.filter(s -> !s.isEmpty())
.toList();
}
private List<String> parseAiResponse(String aiResponse) {
return Arrays.stream(aiResponse.split("\\|"))
.map(String::trim)
.filter(s -> !s.isEmpty())
.toList();
}
}
Loading