fix: 할인 알림 설정 방식을 직접 가격 입력에서 할인율 선택으로 변경#165
Merged
kangcheolung merged 1 commit intodevelopfrom Feb 19, 2026
Merged
Conversation
- PriceAlertRequest: targetPrice → discountRate (10/20/30/40%) - PriceAlertService: 상품 현재가 기반으로 targetPrice 계산 후 저장 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
Caution Review failedThe pull request is closed. Walkthrough가격 알림 생성 방식을 변경했습니다. 기존 목표 가격 직접 입력에서 할인율 기반 접근 방식으로 전환되었습니다. 요청 DTO는 목표 가격 대신 할인율(10/20/30/40 중 선택)을 받으며, 서비스 레이어에서 현재 상품 가격에 할인율을 적용하여 실제 목표 가격을 계산합니다. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔍️ 작업 내용
할인 알림 설정 방식을 직접 가격 입력에서 할인율 선택으로 변경
✨ 상세 설명
🛠️ 추후 리팩토링 및 고도화 계획
📸 스크린샷 (선택)
💬 리뷰 요구사항
Summary by CodeRabbit
새로운 기능