Skip to content

fix: 빈 배열 Redis 캐싱 방지 #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kangcheolung merged 1 commit into from
Mar 3, 2026
Merged

fix: 빈 배열 Redis 캐싱 방지 #167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/main/java/com/ongil/backend/domain/brand/service/BrandService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,9 @@
import com.ongil.backend.global.config.redis.RedisCacheService;

import lombok.RequiredArgsConstructor;
import lombok.extern.slf4j.Slf4j;

@Slf4j
@Service
@RequiredArgsConstructor
@Transactional(readOnly = true)
Expand All @@ -43,14 +45,19 @@ public List<BrandResponse> getAllBrands() {
BrandResponse.class
);

if (cached != null) {
if (cached != null && !cached.isEmpty()) {
return cached;
}

// Cache Miss → DB 조회
List<Brand> brands = brandRepository.findAllOrderByName();
List<BrandResponse> response = brandConverter.toResponseList(brands);

if (response.isEmpty()) {
log.warn("조회된 브랜드가 없습니다.");
return response;
}

// Redis 캐싱 (무한 TTL)
redisCacheService.save(
CacheKeyConstants.BRANDS_ALL,
Expand Down
9 changes: 8 additions & 1 deletion src/main/java/com/ongil/backend/domain/category/service/CategoryService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,9 @@
import com.ongil.backend.global.config.redis.RedisCacheService;

import lombok.RequiredArgsConstructor;
import lombok.extern.slf4j.Slf4j;

@Slf4j
@Service
@RequiredArgsConstructor
@Transactional(readOnly = true)
Expand All @@ -42,7 +44,7 @@ public List<CategoryResponse> getAllCategories() {
CategoryResponse.class
);

if (cached != null) {
if (cached != null && !cached.isEmpty()) {
return cached;
}

Expand All @@ -67,6 +69,11 @@ public List<CategoryResponse> getAllCategories() {
.filter(r -> r != null)
.collect(Collectors.toList());

if (response.isEmpty()) {
log.warn("조회된 카테고리가 없습니다.");
return response;
}

// Redis 캐싱 (무한 TTL)
redisCacheService.save(
CacheKeyConstants.CATEGORIES_ALL,
Expand Down