-
Notifications
You must be signed in to change notification settings - Fork 1
feat: 마이페이지 맞춤형 배너 알림 조회 API 구현 #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| package com.ongil.backend.domain.banner.controller; | ||
|
|
||
| import org.springframework.http.ResponseEntity; | ||
| import org.springframework.security.core.annotation.AuthenticationPrincipal; | ||
| import org.springframework.web.bind.annotation.GetMapping; | ||
| import org.springframework.web.bind.annotation.RequestMapping; | ||
| import org.springframework.web.bind.annotation.RestController; | ||
|
|
||
| import com.ongil.backend.domain.banner.dto.response.BannerResponse; | ||
| import com.ongil.backend.domain.banner.service.BannerService; | ||
| import com.ongil.backend.global.common.dto.DataResponse; | ||
|
|
||
| import io.swagger.v3.oas.annotations.Operation; | ||
| import io.swagger.v3.oas.annotations.tags.Tag; | ||
| import lombok.RequiredArgsConstructor; | ||
|
|
||
| @Tag(name = "Banner", description = "배너 알림 관련 API") | ||
| @RestController | ||
| @RequiredArgsConstructor | ||
| @RequestMapping("/api/banner") | ||
| public class BannerController { | ||
|
|
||
| private final BannerService bannerService; | ||
|
|
||
| @GetMapping | ||
| @Operation(summary = "배너 조회 API", description = "토큰 필요. 현재 사용자에게 보여줄 배너를 조회합니다. 구매 직후 리뷰 유도, 한달 후기 유도, 매거진 추천 중 우선순위에 따라 반환됩니다.") | ||
| public ResponseEntity<DataResponse<BannerResponse>> getBanner( | ||
| @AuthenticationPrincipal Long userId | ||
| ) { | ||
| BannerResponse response = bannerService.getBanner(userId); | ||
| return ResponseEntity.ok(DataResponse.from(response)); | ||
| } | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| package com.ongil.backend.domain.banner.converter; | ||
|
|
||
| import org.springframework.stereotype.Component; | ||
|
|
||
| import com.ongil.backend.domain.banner.dto.response.BannerResponse; | ||
| import com.ongil.backend.domain.banner.enums.BannerType; | ||
|
|
||
| @Component | ||
| public class BannerConverter { | ||
|
|
||
| public BannerResponse toResponse(BannerType type, String title, String buttonText, | ||
| String targetUrl, Long targetId, boolean enabled) { | ||
| return BannerResponse.builder() | ||
| .type(type) | ||
| .title(title) | ||
| .buttonText(buttonText) | ||
| .targetUrl(targetUrl) | ||
| .targetId(targetId) | ||
| .enabled(enabled) | ||
| .build(); | ||
| } | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| package com.ongil.backend.domain.banner.dto.response; | ||
|
|
||
| import com.ongil.backend.domain.banner.enums.BannerType; | ||
|
|
||
| import lombok.Builder; | ||
|
|
||
| @Builder | ||
| public record BannerResponse( | ||
| BannerType type, | ||
| String title, | ||
| String buttonText, | ||
| String targetUrl, | ||
| Long targetId, | ||
| boolean enabled | ||
| ) { | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| package com.ongil.backend.domain.banner.enums; | ||
|
|
||
| import lombok.Getter; | ||
| import lombok.RequiredArgsConstructor; | ||
|
|
||
| @Getter | ||
| @RequiredArgsConstructor | ||
| public enum BannerType { | ||
| MAGAZINE("매거진 유도"), | ||
| REVIEW_PROMPT("구매 직후 리뷰 작성 유도"), | ||
| MONTHLY_REVIEW_PROMPT("한달 후 리뷰 작성 유도"); | ||
|
|
||
| private final String description; | ||
| } |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,132 @@ | ||||||
| package com.ongil.backend.domain.banner.service; | ||||||
|
|
||||||
| import java.time.LocalDateTime; | ||||||
| import java.util.List; | ||||||
|
|
||||||
| import org.springframework.stereotype.Service; | ||||||
| import org.springframework.transaction.annotation.Transactional; | ||||||
|
|
||||||
| import com.ongil.backend.domain.banner.converter.BannerConverter; | ||||||
| import com.ongil.backend.domain.banner.dto.response.BannerResponse; | ||||||
| import com.ongil.backend.domain.banner.enums.BannerType; | ||||||
| import com.ongil.backend.domain.order.entity.Order; | ||||||
| import com.ongil.backend.domain.order.entity.OrderItem; | ||||||
| import com.ongil.backend.domain.order.enums.OrderStatus; | ||||||
| import com.ongil.backend.domain.order.repository.OrderRepository; | ||||||
| import com.ongil.backend.domain.review.enums.ReviewType; | ||||||
| import com.ongil.backend.domain.review.repository.ReviewRepository; | ||||||
|
|
||||||
| import lombok.RequiredArgsConstructor; | ||||||
|
|
||||||
| @Service | ||||||
| @RequiredArgsConstructor | ||||||
| @Transactional(readOnly = true) | ||||||
| public class BannerService { | ||||||
|
|
||||||
| private final OrderRepository orderRepository; | ||||||
| private final ReviewRepository reviewRepository; | ||||||
| private final BannerConverter bannerConverter; | ||||||
|
|
||||||
| public BannerResponse getBanner(Long userId) { | ||||||
| // 1순위: 구매직후 후기 미작성 | ||||||
| BannerResponse initialReviewBanner = checkInitialReviewBanner(userId); | ||||||
| if (initialReviewBanner != null) { | ||||||
| return initialReviewBanner; | ||||||
| } | ||||||
|
|
||||||
| // 2순위: 한달 후 후기 미작성 | ||||||
| BannerResponse monthlyReviewBanner = checkMonthlyReviewBanner(userId); | ||||||
| if (monthlyReviewBanner != null) { | ||||||
| return monthlyReviewBanner; | ||||||
| } | ||||||
|
|
||||||
| // 3순위: 매거진 유도 알림 | ||||||
| return createMagazineBanner(); | ||||||
| } | ||||||
|
|
||||||
| private BannerResponse checkInitialReviewBanner(Long userId) { | ||||||
| List<Order> confirmedOrders = orderRepository.findByUserIdAndStatus( | ||||||
| userId, | ||||||
| OrderStatus.CONFIRMED | ||||||
| ); | ||||||
|
|
||||||
| for (Order order : confirmedOrders) { | ||||||
| OrderItem pendingItem = findPendingInitialReviewItem(order); | ||||||
| if (pendingItem != null) { | ||||||
| return bannerConverter.toResponse( | ||||||
| BannerType.REVIEW_PROMPT, | ||||||
| "구매하신 상품은 어떠셨나요?", | ||||||
| "작성하러 가기", | ||||||
| "/review/write", | ||||||
| order.getId(), | ||||||
| true | ||||||
| ); | ||||||
|
||||||
| } | ||||||
| } | ||||||
|
|
||||||
| return null; | ||||||
| } | ||||||
|
|
||||||
| private BannerResponse checkMonthlyReviewBanner(Long userId) { | ||||||
| LocalDateTime fiveDaysAgo = LocalDateTime.now().minusDays(5); | ||||||
|
|
||||||
| List<Order> orders = orderRepository.findByUserIdAndStatusAndConfirmedAtBefore( | ||||||
| userId, | ||||||
| OrderStatus.CONFIRMED, | ||||||
| fiveDaysAgo | ||||||
| ); | ||||||
|
Comment on lines
+96
to
+103
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: fd BannerService.javaRepository: IT-Cotato/12th-OnGil-BE Length of output: 139 🏁 Script executed: cat -n src/main/java/com/ongil/backend/domain/banner/service/BannerService.java | head -100Repository: IT-Cotato/12th-OnGil-BE Length of output: 3515 🏁 Script executed: rg "checkMonthlyReviewBanner" -A 30 -B 5Repository: IT-Cotato/12th-OnGil-BE Length of output: 6586 🏁 Script executed: rg "한달|monthly|Monthly" --type javaRepository: IT-Cotato/12th-OnGil-BE Length of output: 3315 🏁 Script executed: rg "주문 완료 5일 후" -A 10 -B 5Repository: IT-Cotato/12th-OnGil-BE Length of output: 1849 🏁 Script executed: rg "findPendingMonthlyReviewItem" -A 20Repository: IT-Cotato/12th-OnGil-BE Length of output: 3316 🏁 Script executed: fd -e java -path "*/test/*" BannerService | head -5Repository: IT-Cotato/12th-OnGil-BE Length of output: 235 🏁 Script executed: rg "ONE_MONTH" -A 5 -B 5 --type javaRepository: IT-Cotato/12th-OnGil-BE Length of output: 9555 상수명과 실제 임계값의 의도 불일치를 정합성 있게 정리해야 합니다. 5일 기준은 ReviewService의
변경할 경우 BannerService만 수정하면 ReviewService와 불일치하므로, 설계 의도를 명확히 한 뒤 양쪽을 함께 정합하세요:
🤖 Prompt for AI Agents |
||||||
|
|
||||||
| for (Order order : orders) { | ||||||
| OrderItem pendingItem = findPendingMonthlyReviewItem(order); | ||||||
| if (pendingItem != null) { | ||||||
| return bannerConverter.toResponse( | ||||||
| BannerType.MONTHLY_REVIEW_PROMPT, | ||||||
| "한달 후기를 작성해주세요!", | ||||||
| "작성하러 가기", | ||||||
|
||||||
| "/review/monthly/write", | ||||||
| order.getId(), | ||||||
|
||||||
| order.getId(), | |
| pendingItem.getId(), |
Copilot
AI
Jan 28, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This loop can trigger N+1 DB access: order.getOrderItems() is likely lazy (one query per order), and existsByOrderItemIdAndReviewType(...) runs once per item. Consider fetching needed orderItems eagerly (fetch join / @EntityGraph) and checking review existence in bulk (e.g., query reviewed orderItemIds for the user+type) to avoid many small queries.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
cd src/main/java/com/ongil/backend/domain/banner && find . -type f -name "*.java"Repository: IT-Cotato/12th-OnGil-BE
Length of output: 222
🏁 Script executed:
cat -n src/main/java/com/ongil/backend/domain/banner/service/BannerService.java | head -150Repository: IT-Cotato/12th-OnGil-BE
Length of output: 4410
🏁 Script executed:
find . -path "*/order/repository/*" -name "*.java" | head -5Repository: IT-Cotato/12th-OnGil-BE
Length of output: 228
🏁 Script executed:
find . -path "*/review/repository/*" -name "*.java" | head -5Repository: IT-Cotato/12th-OnGil-BE
Length of output: 235
🏁 Script executed:
cat -n src/main/java/com/ongil/backend/domain/order/repository/OrderRepository.javaRepository: IT-Cotato/12th-OnGil-BE
Length of output: 2493
🏁 Script executed:
cat -n src/main/java/com/ongil/backend/domain/review/repository/ReviewRepository.javaRepository: IT-Cotato/12th-OnGil-BE
Length of output: 8046
🏁 Script executed:
find . -path "*/order/entity/*" -name "Order.java"Repository: IT-Cotato/12th-OnGil-BE
Length of output: 131
🏁 Script executed:
cat -n src/main/java/com/ongil/backend/domain/order/entity/Order.javaRepository: IT-Cotato/12th-OnGil-BE
Length of output: 3461
🏁 Script executed:
find . -path "*/order/entity/*" -name "OrderItem.java"Repository: IT-Cotato/12th-OnGil-BE
Length of output: 135
🏁 Script executed:
cat -n src/main/java/com/ongil/backend/domain/order/entity/OrderItem.javaRepository: IT-Cotato/12th-OnGil-BE
Length of output: 2045
🏁 Script executed:
cat -n src/main/java/com/ongil/backend/domain/review/entity/Review.java | head -50Repository: IT-Cotato/12th-OnGil-BE
Length of output: 1827
주문/아이템 반복 순회 + 항목별 exists 호출로 N+1 쿼리 발생 확인됨
checkInitialReviewBanner(), checkMonthlyReviewBanner() 메서드에서:
findByUserIdAndStatus()또는findByUserIdAndStatusAndConfirmedAtBefore()→ 1회 조회- 각 Order마다
order.getOrderItems()→ 지연로딩으로 N회 추가 쿼리 - 각 OrderItem마다
reviewRepository.existsByOrderItemIdAndReviewType()→ M회 추가 쿼리
Order 엔티티(line 74)의 @OneToMany는 기본값 LAZY로 설정되어 있어 반복문 내 getOrderItems() 호출마다 DB 쿼리가 발생합니다. 확정 주문이 많은 사용자의 경우 쿼리 폭증으로 인한 성능 저하가 명확합니다.
JOIN FETCH, 서브쿼리, 또는 IN 절 기반 일괄 조회 최적화를 권장합니다. 예를 들어 미작성 리뷰 아이템을 DB에서 한 번에 조회하는 방식으로 개선 가능합니다.
🤖 Prompt for AI Agents
In `@src/main/java/com/ongil/backend/domain/banner/service/BannerService.java`
around lines 47 - 118, Both checkInitialReviewBanner and
checkMonthlyReviewBanner cause N+1 queries because order.getOrderItems() is LAZY
and each OrderItem triggers reviewRepository.existsByOrderItemIdAndReviewType;
fix by loading needed OrderItems and review-existence in bulk: change the
orderRepository query used in checkInitialReviewBanner/checkMonthlyReviewBanner
to fetch orders with items (e.g., JOIN FETCH or a new repository method that
returns orders with orderItems) or separately load all OrderItems for the
returned orders using a single query, then call reviewRepository with an
IN-based query (e.g., exists or find by orderItemId IN and ReviewType) to get
all reviewed item IDs at once and use that set inside
findPendingInitialReviewItem/findPendingMonthlyReviewItem to avoid per-item
exists calls.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,62 @@ | ||
| package com.ongil.backend.domain.order.repository; | ||
|
|
||
| import java.time.LocalDateTime; | ||
| import java.util.List; | ||
|
|
||
| import org.springframework.data.jpa.repository.JpaRepository; | ||
| import org.springframework.data.jpa.repository.Query; | ||
| import org.springframework.data.repository.query.Param; | ||
|
|
||
| import com.ongil.backend.domain.order.entity.Order; | ||
| import com.ongil.backend.domain.order.enums.OrderStatus; | ||
|
|
||
| public interface OrderRepository extends JpaRepository<Order, Long> { | ||
|
|
||
| // 특정 사용자의 주문 확정 시간 범위로 주문 조회 | ||
| @Query("SELECT o FROM Order o " + | ||
| "WHERE o.user.id = :userId " + | ||
| "AND o.orderStatus = :status " + | ||
| "AND o.confirmedAt >= :startTime " + | ||
| "AND o.confirmedAt < :endTime " + | ||
| "ORDER BY o.confirmedAt DESC") | ||
| List<Order> findByUserIdAndStatusAndConfirmedAtBetween( | ||
| @Param("userId") Long userId, | ||
| @Param("status") OrderStatus status, | ||
| @Param("startTime") LocalDateTime startTime, | ||
| @Param("endTime") LocalDateTime endTime | ||
| ); | ||
|
|
||
| // 특정 사용자의 주문 확정 시간 이후 주문 조회 (5일 전 이후 확정된 주문) | ||
| @Query("SELECT o FROM Order o " + | ||
| "WHERE o.user.id = :userId " + | ||
| "AND o.orderStatus = :status " + | ||
| "AND o.confirmedAt >= :afterTime " + | ||
| "ORDER BY o.confirmedAt ASC") | ||
| List<Order> findByUserIdAndStatusAndConfirmedAtAfter( | ||
| @Param("userId") Long userId, | ||
| @Param("status") OrderStatus status, | ||
| @Param("afterTime") LocalDateTime afterTime | ||
| ); | ||
|
Comment on lines
+29
to
+39
|
||
|
|
||
| // 특정 사용자의 특정 상태 주문 조회 | ||
| @Query("SELECT o FROM Order o " + | ||
| "WHERE o.user.id = :userId " + | ||
| "AND o.orderStatus = :status " + | ||
| "ORDER BY o.confirmedAt DESC") | ||
| List<Order> findByUserIdAndStatus( | ||
| @Param("userId") Long userId, | ||
| @Param("status") OrderStatus status | ||
| ); | ||
|
|
||
| // 특정 사용자의 주문 확정 시간 이전 주문 조회 (한달 이상 경과) | ||
| @Query("SELECT o FROM Order o " + | ||
| "WHERE o.user.id = :userId " + | ||
| "AND o.orderStatus = :status " + | ||
| "AND o.confirmedAt <= :beforeTime " + | ||
| "ORDER BY o.confirmedAt DESC") | ||
|
Comment on lines
+51
to
+56
|
||
| List<Order> findByUserIdAndStatusAndConfirmedAtBefore( | ||
| @Param("userId") Long userId, | ||
| @Param("status") OrderStatus status, | ||
| @Param("beforeTime") LocalDateTime beforeTime | ||
| ); | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
findByUserIdAndStatus(...)loads all confirmed orders for the user, then scans them in memory. For users with many historical orders this can be expensive. Consider narrowing the query window (e.g., only recent confirmed orders for the “구매직후” banner) and/or using paging/limit so this endpoint stays fast.