Merged
Conversation
bk-git-hub
reviewed
Mar 19, 2026
Collaborator
bk-git-hub
left a comment
bk-git-hub
left a comment
There was a problem hiding this comment.
민서님 고생 많으셨습니다!
전체적으로는 컴포넌트 역할 분리가 깔끔하고, 할 일 데이터를 배열로 두고 리스트 렌더링으로 푼 방향이 좋았습니다. 코드 잘 확인해보았고, 아래에 몇 가지 개선해보면 좋을 부분들 코멘트로 남겨두었습니다.
| @@ -0,0 +1,17 @@ | |||
| import TodoCard from "./ToDoCard"; | |||
Collaborator
There was a problem hiding this comment.
현재 import 경로의 대소문자가 실제 파일명과 조금 다릅니다. Windows 환경에서는 동작할 수 있지만, 대소문자를 구분하는 환경에서는 import 에러가 날 수 있어서 파일명과 import 경로를 동일하게 맞춰주시면 좋겠습니다.
| import heroImg from './assets/hero.png' | ||
| import './App.css' | ||
| import './App.css'; | ||
| import TodoHeader from './components/ToDoHeader'; |
Collaborator
There was a problem hiding this comment.
현재 이부분도 import 경로의 대소문자가 일치하지 않습니다.
|
|
||
| function TodoList({ todos }: Props) { | ||
| return ( | ||
| <div className="card-list"> |
Collaborator
There was a problem hiding this comment.
현재 할 일 목록은 의미상 리스트이기 때문에, div 대신 ul / li 구조로 작성하면 조금 더 시맨틱한 마크업이 될 것 같습니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✅ 제출 정보
✅ 체크리스트 (필수)
main이 아니라 내 GitHub 핸들 브랜치(<handle>)다<handle>-week-xx형식이다🧩 구현 내용 요약
❓ 궁금한 점