Merged
Conversation
bk-git-hub
reviewed
Mar 19, 2026
Collaborator
bk-git-hub
left a comment
bk-git-hub
left a comment
There was a problem hiding this comment.
유빈님 고생 많으셨습니다!
전반적으로 깔끔해서 간단하게 한 개 코멘트만 남겨두었습니다
다음부턴 저희 커밋도 다른 프로젝트에서 유빈님이 쓰셨던 커밋 컨벤션처럼 작업단위로 분리해서 올려보시면 좋을 것 같아요
https://www.notion.so/Git-Commit-Guide-327793efb80180bcb8f9c357c580a48d
|
|
||
| export default function TodoList({ todos }: Props) { | ||
| return ( | ||
| <div className="card-list"> |
Collaborator
There was a problem hiding this comment.
현재 할 일 목록은 의미상 리스트이기 때문에, div 대신 ul / li 구조로 작성하면 조금 더 시맨틱한 마크업이 될 것 같습니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✅ 제출 정보
✅ 체크리스트 (필수)
main이 아니라 내 GitHub 핸들 브랜치(<handle>)다<handle>-week-xx형식이다🧩 구현 내용 요약
-TodoCard, TodoHeader, TodoList 컴포넌트 분리
-React, TypeScript를 이용하여 투두앱의 기본 화면 완
❓ 궁금한 점