Skip to content

Conversation

@giancarloromeo
Copy link
Contributor

@giancarloromeo giancarloromeo commented Jul 22, 2025

What do these changes do?

This PR removes the workbench column from the projects database table, completing the migration from storing node data in the projects table to the dedicated projects_nodes table. This is a major database schema change that required extensive refactoring throughout the codebase.

Removal of the workbench column from the projects table definition and migration of all node data to projects_nodes table
Replacement of direct workbench access with queries to projects_nodes table using a subquery pattern
Updates to all test fixtures and utilities to use the new projects_nodes based approach

image

Related issue/s

How to test

Dev-ops

@giancarloromeo giancarloromeo added this to the Engage milestone Jul 22, 2025
@giancarloromeo giancarloromeo self-assigned this Jul 22, 2025
@giancarloromeo giancarloromeo added the a:webserver webserver's codebase. Assigning the area is particularly useful for bugs label Jul 22, 2025
@codecov
Copy link

codecov bot commented Jul 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.16%. Comparing base (b29169a) to head (3e6b518).

❗ There is a different number of reports uploaded between BASE (b29169a) and HEAD (3e6b518). Click for more details.

HEAD has 18 uploads less than BASE
Flag BASE (b29169a) HEAD (3e6b518)
unittests 32 14
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #8141       +/-   ##
===========================================
- Coverage   87.55%   73.16%   -14.39%     
===========================================
  Files        2012     1210      -802     
  Lines       79039    50786    -28253     
  Branches     1368      717      -651     
===========================================
- Hits        69204    37159    -32045     
- Misses       9429    13444     +4015     
+ Partials      406      183      -223     
Flag Coverage Δ *Carryforward flag
integrationtests 63.97% <ø> (+0.02%) ⬆️ Carriedforward from 9cefdc0
unittests 86.72% <100.00%> (+0.43%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Components Coverage Δ
pkg_aws_library 94.98% <ø> (ø)
pkg_celery_library 83.22% <ø> (ø)
pkg_dask_task_models_library 79.37% <ø> (ø)
pkg_models_library 92.90% <100.00%> (+<0.01%) ⬆️
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration 72.76% <ø> (ø)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library 90.29% <ø> (ø)
pkg_simcore_sdk 84.95% <ø> (ø)
agent 93.10% <ø> (ø)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper 99.14% <ø> (ø)
dask_sidecar 91.72% <ø> (ø)
datcore_adapter 97.95% <ø> (ø)
director 75.90% <ø> (+0.17%) ⬆️
director_v2 78.09% <ø> (-12.86%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 81.89% <ø> (-8.55%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations 90.90% <ø> (ø)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 58.96% <ø> (-28.05%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b29169a...3e6b518. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 6, 2025

@pcrespov pcrespov modified the milestones: Voyager, Imparable Oct 20, 2025
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖-do-not-merge (optional) blocks Mergify from merging the PR a:webserver webserver's codebase. Assigning the area is particularly useful for bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants