You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These environment variables additions/changes should allow to set specific labels and placement constraints on any service started by the director-v0 (legacy services) and the director-v2 (newer services). This is in essence what is needed to have autoscaling for everything.
adds ENVironments to pass custom labels to any created dynamic service by adding DYNAMIC_SIDECAR_CUSTOM_LABELS
modify DIRECTOR_SERVICES_CUSTOM_CONSTRAINTS environment variable to become a list instead of a single string
❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 87.12%. Comparing base (87a16bc) to head (5a1161a).
sanderegg
changed the title
✨Autoscaling is default: Add services custom labels on dynamic services
✨Autoscaling is default: Add services custom labels on dynamic services (⚠️ DevOPS)
Nov 21, 2025
a:autoscalingautoscaling service in simcore's stacka:directorissue related with the director servicea:director-v2issue related with the director-v2 service
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
These environment variables additions/changes should allow to set specific labels and placement constraints on any service started by the director-v0 (legacy services) and the director-v2 (newer services). This is in essence what is needed to have autoscaling for everything.
DYNAMIC_SIDECAR_CUSTOM_LABELSDIRECTOR_SERVICES_CUSTOM_CONSTRAINTSenvironment variable to become a list instead of a single stringDIRECTOR_SERVICES_CUSTOM_LABELSRelated issue/s
How to test
Dev-ops