Skip to content

Conversation

@sanderegg
Copy link
Member

@sanderegg sanderegg commented Nov 21, 2025

What do these changes do?

These environment variables additions/changes should allow to set specific labels and placement constraints on any service started by the director-v0 (legacy services) and the director-v2 (newer services). This is in essence what is needed to have autoscaling for everything.

  • adds ENVironments to pass custom labels to any created dynamic service by adding DYNAMIC_SIDECAR_CUSTOM_LABELS
  • modify DIRECTOR_SERVICES_CUSTOM_CONSTRAINTS environment variable to become a list instead of a single string
  • adds DIRECTOR_SERVICES_CUSTOM_LABELS

Related issue/s

How to test

Dev-ops

@sanderegg sanderegg added this to the Imparable milestone Nov 21, 2025
@sanderegg sanderegg self-assigned this Nov 21, 2025
@sanderegg sanderegg added a:director issue related with the director service a:director-v2 issue related with the director-v2 service a:autoscaling autoscaling service in simcore's stack labels Nov 21, 2025
@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 87.12%. Comparing base (87a16bc) to head (5a1161a).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8629      +/-   ##
==========================================
- Coverage   87.13%   87.12%   -0.02%     
==========================================
  Files        2010     2010              
  Lines       79007    79010       +3     
  Branches     1377     1377              
==========================================
- Hits        68844    68837       -7     
- Misses       9764     9774      +10     
  Partials      399      399              
Flag Coverage Δ
integrationtests 63.84% <100.00%> (-0.14%) ⬇️
unittests 86.19% <71.42%> (+<0.01%) ⬆️
Components Coverage Δ
pkg_aws_library 95.30% <ø> (ø)
pkg_celery_library 83.43% <ø> (ø)
pkg_dask_task_models_library 79.37% <ø> (ø)
pkg_models_library 92.83% <ø> (ø)
pkg_notifications_library 85.20% <ø> (ø)
pkg_postgres_database 88.03% <ø> (ø)
pkg_service_integration 72.76% <ø> (ø)
pkg_service_library 71.12% <ø> (ø)
pkg_settings_library 90.21% <ø> (ø)
pkg_simcore_sdk 84.51% <ø> (-0.07%) ⬇️
agent 93.44% <ø> (ø)
api_server 91.37% <ø> (ø)
autoscaling 95.83% <ø> (ø)
catalog 92.06% <ø> (ø)
clusters_keeper 99.14% <ø> (ø)
dask_sidecar 91.72% <ø> (ø)
datcore_adapter 97.95% <ø> (ø)
director 75.72% <75.00%> (+0.04%) ⬆️
director_v2 91.17% <100.00%> (-0.15%) ⬇️
dynamic_scheduler 96.66% <ø> (ø)
dynamic_sidecar 82.00% <ø> (ø)
efs_guardian 89.83% <ø> (ø)
invitations 90.90% <ø> (ø)
payments 92.70% <ø> (ø)
resource_usage_tracker 92.27% <ø> (+0.10%) ⬆️
storage 86.74% <ø> (+0.11%) ⬆️
webclient ∅ <ø> (∅)
webserver 86.70% <ø> (-0.02%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87a16bc...5a1161a. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sanderegg sanderegg force-pushed the add-dynamic-sidecar-custom-labels branch from 0990879 to 5a1161a Compare November 21, 2025 14:31
@sonarqubecloud
Copy link

@sanderegg sanderegg changed the title ✨Autoscaling is default: Add services custom labels on dynamic services ✨Autoscaling is default: Add services custom labels on dynamic services (⚠️ DevOPS) Nov 21, 2025
@mergify
Copy link
Contributor

mergify bot commented Nov 21, 2025

🧪 CI Insights

Here's what we observed from your CI run for 5a1161a.

❌ Job Failures

Pipeline Job Health on master Retries 🔍 CI Insights 📄 Logs
CI unit-tests Broken 3 View View

✅ Passed Jobs With Interesting Signals

Pipeline Job Signal Health on master Retries 🔍 CI Insights 📄 Logs
CI integration-tests Base branch is healthy, but retries were needed. Could be early signs of flakiness 👀 Healthy 1 View View

@sanderegg sanderegg marked this pull request as ready for review November 21, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:autoscaling autoscaling service in simcore's stack a:director issue related with the director service a:director-v2 issue related with the director-v2 service

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant