-
Notifications
You must be signed in to change notification settings - Fork 4
PartitionedGraphs extension for DataGraphs and interface overhaul.
#55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 49 commits
Commits
Show all changes
60 commits
Select commit
Hold shift + click to select a range
a06ca9c
Refactor interface to make more abstract; have `AbstractDataGraph` su…
jack-dunham c9eaeb0
Fix method overwrites
jack-dunham 692b7b6
Remove `NamedGraphs` ext and move code to core module
jack-dunham accfdcb
Make `rename_vertices` generic by making use of `similar_graph` from …
jack-dunham b282355
Get `vertex_data_eltype` and `edge_data_eltype` directly from type pa…
jack-dunham 8e85d6b
Add `Vertex/EdgeDataView` wrappers that lazily act like Dictionaries
jack-dunham e5e8860
The underlying graph type of `DataGraph` now must be a `AbstractNamed…
jack-dunham 7c07b7f
Make `Base.reverse` method `AbstractDataGraph` more generic.
jack-dunham 6b48268
Remove surplus code
jack-dunham f0e5bce
`PartitionedGraphs` extension for `DataGraphs`.
jack-dunham 1fcb8e6
Write interface in terms of `vertex_data` and `edge_data` rather than…
jack-dunham 925e77b
Interface is now defined in terms of `getindex`.
jack-dunham b48acab
Add `setindex!` fallback methods.
jack-dunham ae97f77
DataViews now use a lazy filter to construct keys
jack-dunham bb9e47c
Remove redundant methods
jack-dunham f51f127
Improve and reorganise indexing interface
jack-dunham 58f0c89
Apply new interface to PartitionedGraphs extension
jack-dunham 9406bf0
Use `quotient_index` function to wrap vertices and edges
jack-dunham 3fd47f4
Move non-abstract function to `abstractdatagraph.jl`
jack-dunham 05ed524
Update PartitionedGraphs extensions
jack-dunham be9c19a
Fix tokenized setindex! for data view objects.
jack-dunham 1cad908
Version bump and NamedGraphs compat.
jack-dunham 260035a
Use correct `to_quotient_index` instead of `quotient_index`.
jack-dunham 61e2f1d
Indexing with `AbstractGraphIndices` now returns a subgraph.
jack-dunham f70e95d
Fix: `getindex` now constructs a `edge_subgraph` when given edges
jack-dunham 446a0e2
Indexing with multiple edges is now undefined, throwing a method error
jack-dunham ebe0e93
Remove duplicate method by using union type QuotientVertexOrVerticesV…
jack-dunham f25331d
Rename `vertex_data_eltype` -> `vertex_data_type`, and similarly for …
jack-dunham 90cf068
Can now assign to `VertexDataView` and `EdgeDataView` using `.=` syntax.
jack-dunham cccea6c
Interface overhaul
jack-dunham f5571b0
Interface cleanup
jack-dunham 152df4c
fix type in partitioned graphs extension
jack-dunham 39f24e2
Fix missing `throw` function calls
jack-dunham cf6942f
Fix implementation forwarding
jack-dunham 99da89f
Remove unnecessary type param
jack-dunham 1c8616e
Fix filling of data using .= when graph is empty
jack-dunham 06eb7cc
DataViews now use #undef to indicate missing data; fixed some bugs re…
jack-dunham c1a8e6d
Add `DataViewSlice` object
jack-dunham 74df9a3
Tests
jack-dunham 3d4472e
Bug fixes regarding `keys` wrapper.
jack-dunham 9dcfcb6
Remove support for unset! rename has_x_data -> is_x_assigned
jack-dunham 9323b72
Add data graph indexing for PartitionedGraph type
jack-dunham ebd5a1e
Fix rem_x! return types
jack-dunham c4d8c07
Make AbstractDataView not insertable
jack-dunham 7744d19
Rename is_index_assigned -> is_graph_index_assigned
jack-dunham 61dc816
Improve default behaviour of data indexing with quotients.
jack-dunham b863965
Fix methods involving setindex! returning wrong type.
jack-dunham 14b82c9
Remove `vertices_data_eltype` and `edges_data_eltype` functions.
jack-dunham 0e8dff6
Remove some methods for `AbstractDataGraph` that have existing sensib…
jack-dunham 54daba5
Remove some commented-out code
jack-dunham 64a79cc
Add code comment regarding branch in `departition(::DataGraph)`
jack-dunham 118e03f
Remove `is_vertices_assigned` etc
jack-dunham f5320fc
Remove trailing .0 in compat entries
jack-dunham ad863d3
Improve codestyle of some functions that check for exceptional cases.
jack-dunham 14257ac
Remove data tranformation kwargs to `quotient_graph` function.
jack-dunham 1fd424e
Improve consistency of graph and dataview indexing with `Indices`; fi…
jack-dunham 5d376d1
Return value codestyle
jack-dunham 59be2b8
Indexing into `AbstractDataView` with `Indices` no longer constructs …
jack-dunham bb845f4
Rename `DataViewSlice` -> `SubDataView`
jack-dunham 51cfcb8
Merge branch 'main' into partitions
mtfishman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.