Skip to content

Fix incorrect one-arg Base.hash for Block in NDTensors #1716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mtfishman merged 2 commits into from
Mar 23, 2026
+2 −3
Merged

Fix incorrect one-arg Base.hash for Block in NDTensors #1716

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fac0cda
Fix incorrect one-arg Base.hash for Block
adienes Mar 19, 2026
3dd6eed
Bump version from 0.4.22 to 0.4.23
mtfishman Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion NDTensors/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name = "NDTensors"
uuid = "23ae76d9-e61a-49c4-8f12-3f1a16adf9cf"
version = "0.4.22"
version = "0.4.23"
authors = ["Matthew Fishman <mfishman@flatironinstitute.org>"]

[workspace]
Expand Down
3 changes: 1 addition & 2 deletions NDTensors/src/blocksparse/block.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,8 +140,7 @@ else
end
end

hash(b::Block) = UInt(b.hash)
hash(b::Block, h::UInt) = h + hash(b)
hash(b::Block, h::UInt) = hash(b.hash, h)

#
# Custom NTuple{N, Int} hashes
Expand Down
Loading