CompatHelper: bump compat for VectorInterface in [weakdeps] to 0.6, (keep existing compat)#1756
Merged
mtfishman merged 2 commits intoMay 30, 2026
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1756 +/- ##
=======================================
Coverage 81.02% 81.02%
=======================================
Files 80 80
Lines 5074 5074
=======================================
Hits 4111 4111
Misses 963 963
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ee3536d to
4cbce7e
Compare
…keep existing compat)
CompatHelper missed this one because the test env isn't a separately registered subpackage. Without it, CheckCompatBounds reports an empty intersection between VectorInterface@0.6.0 and the test workspace project's compat "0.5". Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
4cbce7e to
a7a6c49
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request changes the compat entry for the
VectorInterfacepackage from0.4, 0.5to0.4, 0.5, 0.6in the rootProject.toml([weakdeps]) and from0.5to0.5, 0.6intest/Project.toml. This keeps the compat entries for earlier versions.test/Project.tomlwasn't covered by CompatHelper but is needed so the test workspace project doesn't cap VectorInterface at 0.5 — without it CheckCompatBounds reports an empty intersection between VectorInterface@0.6.0 and the test project's compat.The NDTensors subdir bump lives in its own PR (#1755) since NDTensors is a separately registered package.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.