Add busy checks to peripheral, prevents error if scan or other operation is already running.#465
Open
RenierM26 wants to merge 3 commits intoIanHarvey:masterfrom
Open
Add busy checks to peripheral, prevents error if scan or other operation is already running.#465RenierM26 wants to merge 3 commits intoIanHarvey:masterfrom
RenierM26 wants to merge 3 commits intoIanHarvey:masterfrom
Conversation
-Isort -Pylint -Remove exception condition that has no effect.
RenierM26
commented
Nov 7, 2021
Comment on lines
+450
to
+452
| if self._helper is None: | ||
| self._startHelper(iface) | ||
|
|
Author
There was a problem hiding this comment.
Allows user to retry on "non terminal" errors without stopping helper.
RenierM26
commented
Nov 7, 2021
Comment on lines
+464
to
473
| while rsp.get("state") and rsp["state"][0] in [ | ||
| "tryconn", | ||
| "scan", | ||
| "disc", | ||
| ]: # Wait for any operations to finish. | ||
| rsp = self._getResp("stat", timeout) | ||
|
|
||
| if rsp is None or rsp['state'][0] != 'conn': | ||
| self._stopHelper() | ||
| if rsp is None: |
Author
There was a problem hiding this comment.
Simplifies code and won't give key error if rsp = None.
RenierM26
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request should prevent connection errors when scan or other operation is in progress.