Fix broken Samba user management functions in helper.sh #2359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description: This corrects a typo in the helper script that prevented Samba user management from working. Functions were originally defined as EditSmabaUserPassword and AddSmabaUser. Because of the misspelling, they were never called, and Samba passwords were not being set. Changes: Renamed EditSmabaUserPassword → EditSambaUserPassword Renamed AddSmabaUser → AddSambaUser Impact: Samba password changes and user additions will now function correctly. No backward-compatibility issues, since nothing was successfully calling the typo’d functions before. Notes: This resolves a long-standing bug where Samba accounts were not being properly configured. Signed-off-by: Kev <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This corrects a typo in the helper script that prevented Samba user management from working.
Functions were originally defined as EditSmabaUserPassword and AddSmabaUser.
Because of the misspelling, they were never called, and Samba passwords were not being set.
Changes:
Renamed EditSmabaUserPassword → EditSambaUserPassword
Renamed AddSmabaUser → AddSambaUser
Impact:
Samba password changes and user additions will now function correctly.
No backward-compatibility issues, since nothing was successfully calling the typo’d functions before.
Notes:
This resolves a long-standing bug where Samba accounts were not being properly configured.