-
Notifications
You must be signed in to change notification settings - Fork 584
*#Stop(): wait for own Checkable#ProcessCheckResult() to finish🏁 #10397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Al2Klimov
wants to merge
26
commits into
master
Choose a base branch
from
activation-priority-10179
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows .ti classes multiple inheritance from Object.
Well, that's indeed necessary.
Interesting that I've said something about a comment I haven't even seen until just now. |
ce0d035
to
5b1c4b5
Compare
@julianbrost Very funny. Fact is, on Thursday you
So I've done that. So far:
Finally, CheckResultProducer::Ptr just has to be passed through. |
a0ad767
to
a06b01a
Compare
ea36975
to
a06b01a
Compare
… CheckResultProducer::Ptr
72a171d
to
4873a34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the very first and hardest step of the #10179 (comment) plan.
Checkable#ProcessCheckResult() now takes a CheckResultProducer::Ptr:
It tries to shared-lock the CheckResultProducer:
This implies that every component producing checks needs to implement CheckResultProducer:
Finally, the CheckResultProducer::Ptr has "just" to be passed through from the CheckResultProducer itself to Checkable#ProcessCheckResult():