Fix windows build errors with boost 1.88.0
#10419
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Boost 1.88.0 introduced a feature 1 that makes use of the Windows API, so we need to link against the psapi library. Actually, that new feature can also be disabled by setting the
BOOST_STACKTRACE_DISABLE_OFFSET_ADDR_BASE
macro, but since it seems to be a useful feature and isn't even disabled by default, it's better to add the missing library to the linker flags instead of disabling it.Note: The reason why we're linking statically (psapi.lib) instead of dynamically (psapi.dll) is that we've already set boost to link statically here, so we need to do the same for psapi.
icinga2/CMakeLists.txt
Lines 135 to 136 in 520aed6
fixes #10412
Footnotes
https://github.com/boostorg/stacktrace/pull/200 ↩