Serialize fields before queueing it to the workqueue #10420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhabteab
added
bug
|
Can you please try to split that huge commit into smaller pieces, making it easier to follow the individual changes. The PR description already gives a good example of a part that could easily be split off:
Ideally, there are separate commits for moving and changing code, otherwise, changes happening in the same step tend do be quite hidden. |
yhabteab
force-pushed
the
bundled-perfdata-writers-fix
branch
from
4e0294f to
3df997c
Compare
Done! |
They're just useless, since a `CheckResult` handler is never going to be called without a check result and a checkable can't exist without a checkcommand.
yhabteab
force-pushed
the
bundled-perfdata-writers-fix
branch
2 times, most recently
from
4ab4b33 to
0430d47
Compare
jschmidt-icinga
previously approved these changes
May 14, 2025
yhabteab
force-pushed
the
bundled-perfdata-writers-fix
branch
from
0430d47 to
cef6fb7
Compare
|
Sorry, I had to force push again because I missed one |
jschmidt-icinga
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, all the event handlers of our perfdata writers were directly enqueued into their own work queue, which then extracted all the required metrics from the checkable object. However, since this is done a differently different thread than the one that is used to process the check result, the checkable could change its state in the meantime leading to an inconsistent state. Therefore, all the required metrics are now extracted within the same thread that triggered the event and then enqueued into the work queue. Apart from that, I've removed a lot of useless
if (cr) ...statements, since aCheckResulthandler is never going to be called without a validCheckResult.fixes #10406