Skip to content

WIP: GelfWriter: Implement support for event type filters #7868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dnsmichi
Copy link
Contributor

@dnsmichi dnsmichi commented Feb 27, 2020

Found this in my local branch list from 2018.

TODOs:

  • Tests
  • Documentation

@dnsmichi dnsmichi added area/graylog Events to Graylog enhancement New feature or request labels Feb 27, 2020
@Al2Klimov Al2Klimov marked this pull request as draft June 29, 2020 10:10
@Al2Klimov Al2Klimov added this to the 2.13.0 milestone Nov 23, 2020
@julianbrost julianbrost removed this from the 2.13.0 milestone May 31, 2021
@julianbrost
Copy link
Contributor

Can anyone with more knowledge about Graylog tell if this is something that would be useful?

@N-o-X
Copy link
Contributor

N-o-X commented Sep 20, 2021

After talking to @xtruthx about this, we came to the conclusion that this indeed could be very helpful. Especially for those that use the Graylog Cloud which only offers volume based subscriptions.

Copy link
Member

@Al2Klimov Al2Klimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes do what they promise. Do we want this?

@Al2Klimov Al2Klimov added the TBD To be defined - We aren't certain about this yet label Feb 1, 2023
@Al2Klimov
Copy link
Member

IMAO yes. #7868 (comment)

@Al2Klimov Al2Klimov added needs feedback We'll only proceed once we hear from you again and removed needs feedback We'll only proceed once we hear from you again labels May 17, 2023
@Al2Klimov Al2Klimov requested a review from julianbrost May 17, 2023 10:50
@Al2Klimov Al2Klimov added this to the 2.15.0 milestone Jan 21, 2025
@Al2Klimov
Copy link
Member

I'd even document it if there are no other volunteers.

@lippserd
Copy link
Member

lippserd commented Feb 4, 2025

I would rather close this PR as literally no one has asked for such a feature and so this is work for nothing.

@lippserd lippserd removed this from the 2.15.0 milestone Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/graylog Events to Graylog enhancement New feature or request TBD To be defined - We aren't certain about this yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants