Skip to content

Truncate too big notification command lines, fix GelfWriter deadlock and return 503 in /v1/console/* during reload #9947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 20, 2023
Merged

Truncate too big notification command lines, fix GelfWriter deadlock and return 503 in /v1/console/* during reload #9947

merged 3 commits into from
Dec 20, 2023

Conversation

Al2Klimov
Copy link
Member

Al2Klimov and others added 3 commits December 20, 2023 10:46
@Al2Klimov
PluginNotificationTask::ScriptFunc(): on Linux truncate output and co…
0eeac3b 
…mment

not to run into an exec(3) error E2BIG due to a too long argument.
This sends a notification with truncated output instead of not sending.
@Al2Klimov
Prevent calls to command API while the configuration is reloading.
85c5a7c 
Fixes #9840
@Al2Klimov
GelfWriter: protect m_Stream via m_WorkQueue, not ObjectLock(this)
fecb209 
On shutdown or HA re-connect ConfigObject#SetAuthority(false) is called which
does ObjectLock(this) and ConfigObject#Pause(). GelfWriter#Pause(), with the
above ObjectLock, calls m_WorkQueue.Join(). But items inside that also doing
ObjectLock(this) cause a deadlock.
@icinga-probot icinga-probot bot added this to the 2.14.1 milestone Dec 20, 2023
@cla-bot cla-bot bot added the cla/signed label Dec 20, 2023
@icinga-probot icinga-probot bot added area/api REST API area/graphite Metrics to Graphite area/notifications Notification events bug Something isn't working ref/IP labels Dec 20, 2023
@Al2Klimov Al2Klimov requested a review from yhabteab December 20, 2023 09:51
@Al2Klimov Al2Klimov enabled auto-merge December 20, 2023 10:32
@Al2Klimov Al2Klimov merged commit 61d190f into support/2.14 Dec 20, 2023
@Al2Klimov Al2Klimov deleted the 2141morebackport branch December 20, 2023 11:44
@araujorm araujorm mentioned this pull request Jan 3, 2024
Open
@btrnka63 btrnka63 mentioned this pull request Oct 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yhabteab yhabteab yhabteab approved these changes

Assignees
No one assigned
Labels
area/api REST API area/graphite Metrics to Graphite area/notifications Notification events bug Something isn't working cla/signed ref/IP
Projects
None yet
Milestone
2.14.1
Development

Successfully merging this pull request may close these issues.
2 participants
@Al2Klimov @yhabteab