Skip to content

Improved documentation for signing/encryption keys. #986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dino8890
Copy link

@dino8890 dino8890 commented May 10, 2025

These are improvements to the documentation regarding signing and encryption keys, related to the issue #985 .

This is still WIP as I need to investigate how tmp_cert_file and tmp_cert_key are being used. I determined that this is the path where the keys are generated, but I am not sure what the generated keys are being used for.

I investigated Entity, SecurityContext and CryptoBackend to gather information on this, but someone can review this and see if I made a mistake.

Kind regards

@dino8890
Copy link
Author

Update:

It seems that certificate generation is broken, and possibly not usable at all. Configuring tmp_cert_file, tmp_key_file and enabling generate_cert_info breaks the service. This functionality relies on cert_handler_extra_class configuration which is undocumented, and as of right now unused. It's None by default, and it appears to be some kind of interface, with no explanation of what it should do.

This is supposed to be used by SecurityContext, it's CertHandler, specifically the CertHandler.update_cert method.

Perhaps somebody more familiar with the code base should look into this as a separate issue, but the changes made so far are independent and can be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant