Open
Conversation
There was a problem hiding this comment.
Flake8 found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
Pylint found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Add decoders such as the h264, h265 and av1 reference decoders to decode content after encoding. This will help to validate that the encoder is the only changing brick for the pipeline. The decoders does not support Y4M as output format so use a YUV to Y4M converter to generate the files. It will use reference decoder from the fraunhofer institute for h26x and Open Media for AV1.
0fa3e8c to
7f3942c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to validate the output from a common source, the decoding stage should be performed by a reference decoder.
All the encoders are now using the same reference decoder.
Added a reference decoder for:
Fixing #12