Integrate HeyVR experiences in New Tab #1812
Merged
+205
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
felipeerias
force-pushed
the
felipeerias/newTabHeyVR
branch
3 times, most recently
from
f42524d to
7098d21
Compare
|
Conflicts |
felipeerias
force-pushed
the
felipeerias/newTabHeyVR
branch
from
7098d21 to
3d3f77b
Compare
Organize the suggested experiences in the New Tab view into categories. Individual experience items are displayed on grids, separated by headers with the title of each category. The title of the category follows the current language (if supported).
Add support for displaying HeyVR content alongside regular experiences by integrating with the HeyVR API endpoint. RemoteExperiences supports our two data sources (Wolvic and HeyVR) so we are able to update content from one without overwriting the content from the other. SettingsViewModel handles updates from both data sources, parsing and storing the downloaded JSON content. SettingsStore fetches JSON data from the HeyVR endpoint. The upper layers (adapter, recycler view, etc.) are able to continue displaying this data without any changes.
felipeerias
force-pushed
the
felipeerias/newTabHeyVR
branch
from
3d3f77b to
153fc62
Compare
svillar
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on #1804
Add support for displaying HeyVR content alongside regular experiences by integrating with the HeyVR API endpoint.
RemoteExperiences supports our two data sources (Wolvic and HeyVR) so we are able to update content from one without overwriting the content from the other.
SettingsViewModel handles updates from both data sources, parsing and storing the downloaded JSON content.
SettingsStore fetches JSON data from the HeyVR endpoint.
The upper layers (adapter, recycler view, etc.) are able to continue displaying this data without any changes.