-
Notifications
You must be signed in to change notification settings - Fork 20
Page action click opens a popup #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
… version and all others angular versions met while browsing
|
this is interesting! I thought of adding a pop-up before, but never got around to doing it. Could we change the UI to more clearly distinguish between the info that applies to the current app vs historical information from the browsing session? Maybe put the historical data into a separate tab? Later on I'd also like to add a functionality to report the finding to some server so that we can collect info about apps that people find and create a UI to share this info (e.g. sort the reported pages by pagerank or number of reports and create a leader board of some sort). This is definintely just a nice to have feature and I don't see myself having time to implement it any time soon. Just throwing it out there to inform the UI decisions we are making now. |
|
For the UI, I am going to do something about it. Love your feature idea about reporting great angular apps into a dashboard. I can see something like "the most visited app of the month/alltime/day" and so on. |
distingush current tab infomration and historical information
|
how about swapping url and version in history view? |
|
Oh yeah. Haha |
add a normally indexed array in addition of the tab ID index array
Popup 450px to 550px
js files to js folder html files to views folder
Added a 128*128 px icon
|
Any comments on the code/feature ? |
|
Dear @IgorMinar it would be great if you could take a little of your time to review this PR With this table, we could add a button to report a website to a Angular JS hall of fame dashboard (https://builtwith.angularjs.org/) Thanks |
When we click on page action icon, it makes appear a popup containing :
Example :
