Skip to content

Conversation

@polomarcus
Copy link

When we click on page action icon, it makes appear a popup containing :

  • current tab angular version
  • all others angular versions met while browsing

Example :
ng-detecotr

@IgorMinar
Copy link
Owner

this is interesting!

I thought of adding a pop-up before, but never got around to doing it.

Could we change the UI to more clearly distinguish between the info that applies to the current app vs historical information from the browsing session? Maybe put the historical data into a separate tab?

Later on I'd also like to add a functionality to report the finding to some server so that we can collect info about apps that people find and create a UI to share this info (e.g. sort the reported pages by pagerank or number of reports and create a leader board of some sort). This is definintely just a nice to have feature and I don't see myself having time to implement it any time soon. Just throwing it out there to inform the UI decisions we are making now.

@polomarcus
Copy link
Author

For the UI, I am going to do something about it.

Love your feature idea about reporting great angular apps into a dashboard. I can see something like "the most visited app of the month/alltime/day" and so on.
I added a check to avoid adding duplicates apps, we could use this simple check to send only once the app data on a server via an AJAX request.

distingush current tab infomration and historical information
@polomarcus
Copy link
Author

Few UI updates :

ng-detecotr

@IgorMinar
Copy link
Owner

how about swapping url and version in history view?

@polomarcus
Copy link
Author

Oh yeah. Haha

add a normally indexed array in addition of the tab ID index array
Popup 450px to 550px
@polomarcus
Copy link
Author

Changes :

  • fix a bug where if you change your tab to another angular app it will erase the previous app data.
  • Highlight current tab version inside the popup

ng-detector-new

js files to js folder
html files to views folder
Added a 128*128 px icon
@polomarcus
Copy link
Author

Changes :

  • new JS and views folders completing CSS and images folders
  • 128*128 pixel icon to display on the Google Chrome extension page

iconngdectetor

@polomarcus
Copy link
Author

Any comments on the code/feature ?

@polomarcus
Copy link
Author

Dear @IgorMinar it would be great if you could take a little of your time to review this PR

With this table, we could add a button to report a website to a Angular JS hall of fame dashboard (https://builtwith.angularjs.org/)

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants