-
Notifications
You must be signed in to change notification settings - Fork 1
Code review #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Ihebdhouibi
wants to merge
26
commits into
master
Choose a base branch
from
review-branch
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Code review #1
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
e155871
Review- Removing unused imports
Ihebdhouibi 8e43594
Review- Adding windows timeout mechanism
Ihebdhouibi 04bb477
Review- removing obselete code
Ihebdhouibi 694330d
Review- Encapsulate global variable in a config class
Ihebdhouibi 48a7ecf
Review- fixing typo in ScraperConfig class
Ihebdhouibi 9d03605
Review- fixing typo in timeout cnstr
Ihebdhouibi 31fdb56
Review- Fixing search_download call
Ihebdhouibi 34e6cad
Review- missing parentheses
Ihebdhouibi 173afd2
Review- fixing typo
Ihebdhouibi 2c863d7
Review- search_download call fix
Ihebdhouibi d948deb
Review- Establishing DB connection using context manager
Ihebdhouibi 704250c
Review- Removing commented lines
Ihebdhouibi b58e70d
Review- Apply code reusebility to store alerts functions
Ihebdhouibi f7e3782
Review- Apply code reusebility to retrieving alerts functions
Ihebdhouibi 042b951
Review- Add exception handling
Ihebdhouibi 6289aa9
Review- Add remove_camera function
Ihebdhouibi 5a17c59
Review- Fixing typo
Ihebdhouibi d628218
Review- Add exception handling
Ihebdhouibi caebad0
Review- Fixing typo and naming in functions
Ihebdhouibi 8517949
Review- Updating create_azure_container function
Ihebdhouibi 4075fc5
Review- Remove commented lines
Ihebdhouibi f7893a4
Review- Updating upload_blob function
Ihebdhouibi 244dcb2
Review- removing debbuging and unecessary lines
Ihebdhouibi aae9185
Review- Removing unecessary prints
Ihebdhouibi f1e5c12
Review- Removing commented code
Ihebdhouibi 39616c3
Review- Documenting functions
Ihebdhouibi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,14 +22,13 @@ def init_blob_client(): | |
|
|
||
| return blob_service_client | ||
|
|
||
| def create_azure_container(): | ||
| def create_azure_container(container_name = "alerts"): | ||
|
|
||
| blob_service_client = init_blob_client() | ||
|
|
||
| container_name = "alerts" | ||
|
|
||
| container_client = blob_service_client.create_container(container_name) | ||
|
|
||
| try: | ||
| container_client = blob_service_client.create_container(container_name) | ||
| except Exception as e: | ||
| print(f"Error creating container {container_name}: {e}") | ||
|
Comment on lines
-28
to
+31
Owner
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. add exception handling |
||
|
|
||
| def upload_blob(videoArray, videoName, width, height, fps): | ||
|
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
avoid hardcoding the container name for better flexibility