Make boolean query parameter keyword-only (FBT001)

isic/core/api/collection.py

@@ -62,7 +62,7 @@ class Meta:
 )
 @paginate(CursorPagination)
 def collection_list(
-    request, pinned: bool | None = None, sort: Literal["name", "created"] | None = None
+    request, *, pinned: bool | None = None, sort: Literal["name", "created"] | None = None
 ) -> list[CollectionOut]:
     queryset = get_visible_objects(request.user, "core.view_collection", Collection.objects.all())
 

isic/core/management/commands/anonymize_database.py

@@ -459,7 +459,7 @@ def _clear_sensitive_tables(*, dry_run):
     default=1000,
     help="Number of records to process in each batch",
 )
-def anonymize_database(dry_run: bool, batch_size: int):
+def anonymize_database(dry_run: bool, batch_size: int):  # noqa: FBT001
     salt = secrets.token_hex(32)
     faker = Faker()
     faker.seed_instance(int(hashlib.sha256(salt.encode()).hexdigest()[:8], 16))

isic/core/models/__init__.py

@@ -37,7 +37,7 @@
 def add_or_remove_groups(
     sender: type[User],
     instance: User,
-    created: bool,
+    created: bool,  # noqa: FBT001
     **kwargs,
 ):
     from django.contrib.auth.models import Group

isic/core/pagination.py

@@ -228,7 +228,7 @@ def next_link(  # noqa: PLR0913
         page: list,
         cursor: Cursor,
         order: tuple,
-        has_previous: bool,
+        has_previous: bool,  # noqa: FBT001
         limit: int,
         next_position: str,
         previous_position: str,
@@ -288,7 +288,7 @@ def previous_link(  # noqa: PLR0913
         page: list,
         cursor: Cursor,
         order: tuple,
-        has_next: bool,
+        has_next: bool,  # noqa: FBT001
         limit: int,
         next_position: str,
         previous_position: str,

isic/ingest/tests/factories.py

@@ -38,7 +38,7 @@ class Meta:
     creator = factory.SubFactory(UserFactory)
 
     @factory.post_generation
-    def owners(self, create: bool, extracted: Any, **kwargs: Any) -> None:
+    def owners(self, create: bool, extracted: Any, **kwargs: Any) -> None:  # noqa: FBT001
         if not create:
             return
         if extracted is None:
@@ -163,7 +163,7 @@ class Params:
     # https://github.com/pytest-dev/pytest-factoryboy/issues/67
 
     @factory.post_generation
-    def short_diagnosis(self, create: bool, extracted: Any, **kwargs: Any) -> None:
+    def short_diagnosis(self, create: bool, extracted: Any, **kwargs: Any) -> None:  # noqa: FBT001
         if extracted is None:
             # Normal flow, no short_diagnosis provided.
             return
@@ -184,7 +184,7 @@ def short_diagnosis(self, create: bool, extracted: Any, **kwargs: Any) -> None:
             self.save()
 
     @factory.post_generation
-    def short_anatom_site(self, create: bool, extracted: Any, **kwargs: Any) -> None:
+    def short_anatom_site(self, create: bool, extracted: Any, **kwargs: Any) -> None:  # noqa: FBT001
         if extracted is None:
             return
 

isic/login/models.py

@@ -47,7 +47,7 @@ def __str__(self) -> str:
 def create_or_save_user_profile(
     sender: type[User],
     instance: User,
-    created: bool,
+    created: bool,  # noqa: FBT001
     **kwargs,
 ):
     if created:

isic/studies/tests/factories.py

@@ -69,7 +69,7 @@ class Meta:
     public = factory.Faker("boolean")
 
     @factory.post_generation
-    def owners(self, create: bool, extracted: Any, **kwargs: Any) -> None:
+    def owners(self, create: bool, extracted: Any, **kwargs: Any) -> None:  # noqa: FBT001
         if not create:
             return
         if extracted is None:
@@ -78,7 +78,7 @@ def owners(self, create: bool, extracted: Any, **kwargs: Any) -> None:
         self.owners.add(*extracted)
 
     @factory.post_generation
-    def features(self, create: bool, extracted: Any, **kwargs: Any) -> None:
+    def features(self, create: bool, extracted: Any, **kwargs: Any) -> None:  # noqa: FBT001
         if not create:
             return
         if extracted:

pyproject.toml

@@ -175,7 +175,6 @@ ignore = [
   # Project-specific
   "A002", # builtin-argument-shadowing
   "DJ001", # django-nullable-model-string-field
-  "FBT001", # boolean-typed-positional-argument
   "I002", # missing-required-import
   "PLC0415", # import-outside-top-level
   "RET503", # implicit-return