You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
PR #616 defined the return type of getImageBlob() as nullable, but that is no longer correct because PR #606 changed it to throw an exception instead of returning null.
This PR sets the return type of getImageBlob() back to non-nullable and updates getImagesBlob() to throw an exception when it fails to get the image contents. This makes both methods behave consistently.
The getImageBlob type change is correct but I'm wondering if we should rather change type back for getImagesBlob to nullable rather than throwing an exception. There might be some code in old version relying on null being returned so we could consider it as a bug.
I'm wondering if we should rather change type back for getImagesBlob to nullable rather than throwing an exception. There might be some code in old version relying on null being returned so we could consider it as a bug.
@bukka I'm fine either way, but the change to getImageBlob was introduced in 3.8.0, so the same argument could be made for anyone updating from 3.7.0. IMO, having consistent behavior that aligns with the docs is the better choice, but I'm happy to change it if you want.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #616 defined the return type of
getImageBlob()as nullable, but that is no longer correct because PR #606 changed it to throw an exception instead of returning null.This PR sets the return type of
getImageBlob()back to non-nullable and updatesgetImagesBlob()to throw an exception when it fails to get the image contents. This makes both methods behave consistently.