small correction to HF deployment script#28
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Hugging Face deployment workflow to exclude the assets/ directory from what gets pushed to the HF Space.
Changes:
- Adds a workflow step intended to remove
assets/before pushing to Hugging Face.
Comments suppressed due to low confidence (1)
.github/workflows/deploy-to-hf.yml:23
- This step removes
assets/from the CI workspace, but it is never staged/committed, so it will not affect what gets pushed to Hugging Face (git push sends commits, not the working tree). Also,git rm --cached assetsis likely to fail afterrm -rf assetsand is masked by|| true, so tracked assets may remain in the pushed commit. Consider usinggit rm -r --ignore-unmatch assets(or stage deletions withgit add -A) and include the removal in the local commit you push (either as its own commit or by amending the README commit).
caviri
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a small but important change to the Hugging Face deployment workflow by ensuring that the
assetsfolder is removed before pushing to Hugging Face. This prevents unnecessary assets from being included in the deployment.assetsfolder from both the file system and the git index before pushing to Hugging Face in.github/workflows/deploy-to-hf.yml.