Skip to content

small correction to HF deployment script#28

Merged
qchapp merged 1 commit into
mainfrom
update-hf-deploy
Apr 29, 2026
Merged

small correction to HF deployment script#28
qchapp merged 1 commit into
mainfrom
update-hf-deploy

Conversation

@qchapp
Copy link
Copy Markdown
Member

@qchapp qchapp commented Apr 29, 2026

This pull request makes a small but important change to the Hugging Face deployment workflow by ensuring that the assets folder is removed before pushing to Hugging Face. This prevents unnecessary assets from being included in the deployment.

  • Workflow update for Hugging Face deployment:
    • Added a step to remove the assets folder from both the file system and the git index before pushing to Hugging Face in .github/workflows/deploy-to-hf.yml.

Copilot AI review requested due to automatic review settings April 29, 2026 08:18
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Hugging Face deployment workflow to exclude the assets/ directory from what gets pushed to the HF Space.

Changes:

  • Adds a workflow step intended to remove assets/ before pushing to Hugging Face.
Comments suppressed due to low confidence (1)

.github/workflows/deploy-to-hf.yml:23

  • This step removes assets/ from the CI workspace, but it is never staged/committed, so it will not affect what gets pushed to Hugging Face (git push sends commits, not the working tree). Also, git rm --cached assets is likely to fail after rm -rf assets and is masked by || true, so tracked assets may remain in the pushed commit. Consider using git rm -r --ignore-unmatch assets (or stage deletions with git add -A) and include the removal in the local commit you push (either as its own commit or by amending the README commit).

@qchapp qchapp merged commit f03b075 into main Apr 29, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants