Skip to content

fix tempfile #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025
Merged

fix tempfile #414

merged 1 commit into from
Apr 29, 2025

Conversation

barneydobson
Copy link
Collaborator

@barneydobson barneydobson commented Apr 29, 2025

Description

Something to do with tempfile preventing some people from running the notebooks locally

Fixes #364

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature (non-breaking change which adds functionality)
  • Optimization (non-breaking, back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Key checklist

  • All tests pass (eg. python -m pytest)
  • The documentation builds and looks OK (eg. python -m sphinx -b html docs docs/build)
  • Pre-commit hooks run successfully (eg. pre-commit run --all-files)

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added or an issue has been opened to tackle that in the future. (Indicate issue here: # (issue))

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.09%. Comparing base (6682860) to head (d315251).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #414   +/-   ##
=======================================
  Coverage   88.09%   88.09%           
=======================================
  Files          22       22           
  Lines        2252     2252           
  Branches      282      282           
=======================================
  Hits         1984     1984           
  Misses        191      191           
  Partials       77       77           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@barneydobson barneydobson merged commit 11dad15 into main Apr 29, 2025
5 checks passed
@barneydobson barneydobson deleted the tempfile-base-dir branch April 29, 2025 10:01
@barneydobson barneydobson restored the tempfile-base-dir branch April 29, 2025 10:05
@barneydobson
Copy link
Collaborator Author

@meghnathomas did you want to try this branch to see if it fixes your problem?

I already merged it because my office is too hot to concentrate, but hopefully now works, let me know any issues. I'll implement the same fix on the other two notebook issues #395 and #396

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JOSS review
2 participants