Mex codegen #162
Merged
Mex codegen #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djmaxus
added
feature
There was a problem hiding this comment.
Pull request overview
This PR adds MATLAB Coder MEX compilation support to enable performance optimization of the upscale function and related computations. The changes prepare the codebase for MEX code generation by adding proper type annotations, pre-allocating arrays, refactoring iteration patterns, and introducing a CodeGenMex class to manage the compilation process.
Key Changes:
- Added MEX compilation configuration class (CodeGenMex.m) with optimization settings for C++ code generation
- Pre-allocated arrays throughout the codebase for MEX compatibility (idx_adj, map_to_cond, lin_to_sub, h, etc.)
- Added argument blocks with type constraints to multiple functions for better type inference during compilation
- Refactored loop patterns from implicit column iteration to explicit indexing for MATLAB Coder compatibility
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
| src/CodeGenMex.m | New class for managing MEX compilation with optimization settings (contains syntax errors) |
| src/upscale.m | Added arguments block, early return for scalar case, helper functions, and variable pre-allocation for MEX |
| src/upscale_permeability.m | Pre-allocated arrays (idx_adj, map_to_cond, lin_to_sub, A_ndiag) for MEX compatibility |
| src/strata_trapper.m | Added krw monotonization in reverse direction and removed trailing whitespace |
| src/calc_percolation.m | Pre-allocated h array and refactored loop from column iteration to explicit indexing |
| src/Options.m | Updated validation function from mustBeOfClass to mustBeA |
| src/CapPressure.m | Added explicit type constraints for perm arguments and refactored transform_perm with explicit return |
| src/export/opm_export.m | Added named arguments, default_poro/default_perm support, RUNSPEC file generation, and FIPMIP region |
| src/export/common/write_perm.m | Added default_perm parameter with initialization support |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
djmaxus
force-pushed
the
mex-codegen
branch
6 times, most recently
from
08dda3a to
2476669
Compare
djmaxus
force-pushed
the
mex-codegen
branch
5 times, most recently
from
00b27f0 to
337842e
Compare
Introduce `CodeMexGen` class that can compile the `upscale` function into MEX-file to accelerate the toolkit. How to use: ```matlab % 1. compile MEX functions codegen_mex = CodeGenMex().config().build(); % 2. use strata_trapper normally ... % 3. recompile MEX functions when the source code changes codegen_mex.build(); % 4. delete MEX functions to use the original codegen_mex.clear(); ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.