Add subdaily check

[MarionBWeinzierl]

Description

The underlying issue #416 wanted to add a check for SubdailyScaler to make sure that the data is indeed subdaily. The scaler has in the meantime been replaced by the AcclimationModel, which is paired with the SubdailyPModel.

Fixes #416

Type of change

• New feature (non-breaking change which adds functionality)
• Optimization (back-end change that speeds up the code)
• Bug fix (non-breaking change which fixes an issue)

Key checklist

• Make sure you've run the pre-commit checks: $ pre-commit run -a
• All tests pass: $ poetry run pytest

Further checks

• Code is commented, particularly in hard-to-understand areas
• Tests added that prove fix is effective or that feature works

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.92%. Comparing base (b65d912) to head (0579876).
Report is 13 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop     #485   +/-   ##
========================================
  Coverage    96.92%   96.92%           
========================================
  Files           38       38           
  Lines         2955     2957    +2     
========================================
+ Hits          2864     2866    +2     
  Misses          91       91           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[davidorme]

Or does all data in AcclimationModel need to be subdaily -- I suppose not?

The SubdailyPModel and AcclimationModel are basically paired - I don't think we should allow the AcclimationModel to create inputs that SubdailyPModel will reject, so it is probably better placed in AcclimationModel.

It's also marginally more convenient since there is already one check on the spacing attribute:

pyrealm/pyrealm/pmodel/acclimation.py

Lines 222 to 223 in 483976b

	if spacing < 0:
	raise ValueError("Datetime sequence must be increasing")

[davidorme]

LGTM - can we add a test?

[MarionBWeinzierl]

LGTM - can we add a test?

I added a test now