Add login rate limiting, fan profile routes, bookmarks, and activity stream API - #975
Merged
xeeenab merged 2 commits intoAug 30, 2026
Conversation
…stream API - Add per-account and per-IP rate limiting to the login endpoint to mitigate brute-force password guessing, with a test asserting 429. - Add a dedicated fan controller and routes for fan profile read/update, and implement the bookmark repository/service/controller backed by a new persisted Bookmark model (create, list, delete) for mobile/web saved creators, with integration tests. - Expose the activity stream service via an HTTP endpoint with pagination. - Document the new fan, bookmark, and activity endpoints in the OpenAPI spec. Closes InChordSync#832 Closes InChordSync#831 Closes InChordSync#830 Closes InChordSync#829
|
@limxiy Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #832,
Closes #831,
Closes #830,
Closes #829
This PR builds out the missing HTTP surface for the fans and activity modules and adds brute-force protection to login.
Login rate limiting (#832)
The login endpoint had no throttling, leaving brute-force password guessing unmitigated. Added per-account (email) and per-IP rate limiters, both returning 429 once the threshold is exceeded. A test asserts the 429 behaviour.
Fan profile routes (#830)
The fans module had a repository/service/types but no controller or routes. Added
GET/PATCH /api/fans/mefor fan profile read and update, backed by the existingfanService, with integration tests.Fan bookmarks (#831)
The bookmark types existed but had no backend. Implemented a persisted
Bookmarkmodel plus repository/service/controller with create, list, and delete endpoints under/api/fans/me/bookmarks. The endpoints are documented in the OpenAPI spec for mobile/web (SavedCreatorsScreen) consumption, with integration tests.Activity stream API (#829)
The
ActivityStreamServicehad unit tests but no HTTP surface. Exposed it viaGET /api/activity/streamwith optionalcreatorId,page, andpageSizepagination (with metadata).Changes
GET/PATCH /api/fans/me,GET/POST /api/fans/me/bookmarks,DELETE /api/fans/me/bookmarks/:creatorIdBookmarkPrisma model, repository, service, and controllerGET /api/activity/streamcontroller + route with pagination