Add possibility of merge missing nested array values under the top-level key #46
+63
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 please merge this |
|
Any chances to have the PR merged? |
|
I will dedicated some time this weekend to review it |
|
this feature would be nice to have |
|
I think this breaks things for cases where you have a list in an argument (for instance a list of trusted proxies, even though that's the bad example for Symfony projects as trusted proxies are needed earlier than the loading of parameters) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original pull request #36 by @zeliard91
Bug fix: no
Feature addition: yes
Backwards compatibility break: no
Tests pass: yes
With this, we can now have new multi dimensional arrays in the dist file under the top-level key parameter be merged in the generated parameter file.
The prompt is still waiting for a full YAML definition of the missing key.