Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PHP 8.4 deprecations (implicitly nullable arguments). Add PHP 8.4 to CI workflow. #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix PHP 8.4 deprecations (implicitly nullable arguments). Add PHP 8.4 to CI workflow. #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
- uses: shivammathur/setup-php@v2
with:
coverage: none
php-version: '8.3'
php-version: '8.4'
- run: composer validate --strict --no-check-lock

static_analysis:
Expand All @@ -25,7 +25,7 @@ jobs:
- uses: shivammathur/setup-php@v2
with:
coverage: none
php-version: '8.3'
php-version: '8.4'
- name: Install dependencies
run: composer update --ansi --no-progress --prefer-dist --no-interaction
- run: vendor/bin/phpstan analyze
Expand All @@ -37,12 +37,12 @@ jobs:
strategy:
fail-fast: false
matrix:
php: [ '7.4', '8.0', '8.1', '8.2', '8.3' ]
php: [ '7.4', '8.0', '8.1', '8.2', '8.3', '8.4' ]
min_stability: [ '' ]
name_suffix: [ '' ]
composer_flags: [ '' ]
include:
- php: '8.3'
- php: '8.4'
min_stability: 'dev'
name_suffix: ' (dev deps)'
- php: '7.4'
Expand Down
2 changes: 1 addition & 1 deletion src/Asset/HashingVersionStrategy.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ class HashingVersionStrategy implements VersionStrategyInterface
private AssetHasherInterface $hasher;
private string $format;

public function __construct(AssetHasherInterface $hasher, string $format = null)
public function __construct(AssetHasherInterface $hasher, ?string $format = null)
{
$this->format = $format ?: '%s?%s';
$this->hasher = $hasher;
Expand Down
2 changes: 1 addition & 1 deletion src/CacheWarmer/HashCacheWarmer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public function __construct(AssetFinder $assetFinder, string $cacheFile, AssetHa
*
* @return string[]
*/
public function warmUp($cacheDir, string $buildDir = null): array
public function warmUp($cacheDir, ?string $buildDir = null): array
{
$phpArrayPool = new PhpArrayAdapter($this->cacheFile, $this->fallbackPool);
$arrayPool = new ArrayAdapter(0, false);
Expand Down
Loading