This repository was archived by the owner on Aug 28, 2024. It is now read-only.
Filter IPv6 addresses by default#2
Open
JordanMilne wants to merge 2 commits intoIncludeSecurity:mainfrom
Open
Conversation
The examples weren't working for me unless I did this
We can't safely support IPv6 with our default blacklist since even hosts on the intranet will usually have globally-routable addresses. Add a flag to disable IPv6 support and enable it by default. Since we handle this in `resolve()` by filtering IPv6 addresses and raising a `UnknownHostException` when all addresses were IPv6 we maintain API compatibility with previous versions of SafeURL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1
We can't safely support IPv6 with our default blacklist since
even hosts on the intranet will usually have globally-routable addresses.
Add a flag to disable IPv6 support and enable it by default.
Since we handle this in
resolve()by filtering IPv6 addresses andraising a
UnknownHostExceptionwhen all addresses were IPv6 we maintainAPI compatibility with previous versions of SafeURL.