Skip to content

Repository navigation

feat(api): api update #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
increase-releases wants to merge 1 commit into from
Closed

feat(api): api update #311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .stats.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
configured_endpoints: 250
openapi_spec_hash: 554ba5ffa218ca9f21a9fc609beee08f
openapi_spec_hash: a383aac2be26a2594ce455e852c06d29
config_hash: d7ca436bad24fac6653189f8323f3e00
2 changes: 1 addition & 1 deletion scripts/mock
View file
Open in desktop

Large diffs are not rendered by default.

213 changes: 45 additions & 168 deletions src/Increase.Api.Tests/Models/AccountNumbers/AccountNumberCreateParamsTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,19 +15,20 @@ public void FieldRoundtrip_Works()
{
AccountID = "account_in71c4amph0vgo2qllky",
Name = "Rent payments",
InboundAch = new(DebitStatus.Allowed),
InboundChecks = new(Status.Allowed),
InboundAchDebits = InboundAchDebits.Allowed,
UnregisteredInboundChecks = UnregisteredInboundChecks.Allowed,
};

string expectedAccountID = "account_in71c4amph0vgo2qllky";
string expectedName = "Rent payments";
InboundAch expectedInboundAch = new(DebitStatus.Allowed);
InboundChecks expectedInboundChecks = new(Status.Allowed);
ApiEnum<string, InboundAchDebits> expectedInboundAchDebits = InboundAchDebits.Allowed;
ApiEnum<string, UnregisteredInboundChecks> expectedUnregisteredInboundChecks =
UnregisteredInboundChecks.Allowed;

Assert.Equal(expectedAccountID, parameters.AccountID);
Assert.Equal(expectedName, parameters.Name);
Assert.Equal(expectedInboundAch, parameters.InboundAch);
Assert.Equal(expectedInboundChecks, parameters.InboundChecks);
Assert.Equal(expectedInboundAchDebits, parameters.InboundAchDebits);
Assert.Equal(expectedUnregisteredInboundChecks, parameters.UnregisteredInboundChecks);
}

[Fact]
Expand All @@ -39,10 +40,10 @@ public void OptionalNonNullableParamsUnsetAreNotSet_Works()
Name = "Rent payments",
};

Assert.Null(parameters.InboundAch);
Assert.False(parameters.RawBodyData.ContainsKey("inbound_ach"));
Assert.Null(parameters.InboundChecks);
Assert.False(parameters.RawBodyData.ContainsKey("inbound_checks"));
Assert.Null(parameters.InboundAchDebits);
Assert.False(parameters.RawBodyData.ContainsKey("inbound_ach_debits"));
Assert.Null(parameters.UnregisteredInboundChecks);
Assert.False(parameters.RawBodyData.ContainsKey("unregistered_inbound_checks"));
}

[Fact]
Expand All @@ -54,14 +55,14 @@ public void OptionalNonNullableParamsSetToNullAreNotSet_Works()
Name = "Rent payments",

// Null should be interpreted as omitted for these properties
InboundAch = null,
InboundChecks = null,
InboundAchDebits = null,
UnregisteredInboundChecks = null,
};

Assert.Null(parameters.InboundAch);
Assert.False(parameters.RawBodyData.ContainsKey("inbound_ach"));
Assert.Null(parameters.InboundChecks);
Assert.False(parameters.RawBodyData.ContainsKey("inbound_checks"));
Assert.Null(parameters.InboundAchDebits);
Assert.False(parameters.RawBodyData.ContainsKey("inbound_ach_debits"));
Assert.Null(parameters.UnregisteredInboundChecks);
Assert.False(parameters.RawBodyData.ContainsKey("unregistered_inbound_checks"));
}

[Fact]
Expand All @@ -85,8 +86,8 @@ public void CopyConstructor_Works()
{
AccountID = "account_in71c4amph0vgo2qllky",
Name = "Rent payments",
InboundAch = new(DebitStatus.Allowed),
InboundChecks = new(Status.Allowed),
InboundAchDebits = InboundAchDebits.Allowed,
UnregisteredInboundChecks = UnregisteredInboundChecks.Allowed,
};

AccountNumberCreateParams copied = new(parameters);
Expand All @@ -95,84 +96,22 @@ public void CopyConstructor_Works()
}
}

public class InboundAchTest : TestBase
{
[Fact]
public void FieldRoundtrip_Works()
{
var model = new InboundAch { DebitStatus = DebitStatus.Allowed };

ApiEnum<string, DebitStatus> expectedDebitStatus = DebitStatus.Allowed;

Assert.Equal(expectedDebitStatus, model.DebitStatus);
}

[Fact]
public void SerializationRoundtrip_Works()
{
var model = new InboundAch { DebitStatus = DebitStatus.Allowed };

string json = JsonSerializer.Serialize(model, ModelBase.SerializerOptions);
var deserialized = JsonSerializer.Deserialize<InboundAch>(
json,
ModelBase.SerializerOptions
);

Assert.Equal(model, deserialized);
}

[Fact]
public void FieldRoundtripThroughSerialization_Works()
{
var model = new InboundAch { DebitStatus = DebitStatus.Allowed };

string element = JsonSerializer.Serialize(model, ModelBase.SerializerOptions);
var deserialized = JsonSerializer.Deserialize<InboundAch>(
element,
ModelBase.SerializerOptions
);
Assert.NotNull(deserialized);

ApiEnum<string, DebitStatus> expectedDebitStatus = DebitStatus.Allowed;

Assert.Equal(expectedDebitStatus, deserialized.DebitStatus);
}

[Fact]
public void Validation_Works()
{
var model = new InboundAch { DebitStatus = DebitStatus.Allowed };

model.Validate();
}

[Fact]
public void CopyConstructor_Works()
{
var model = new InboundAch { DebitStatus = DebitStatus.Allowed };

InboundAch copied = new(model);

Assert.Equal(model, copied);
}
}

public class DebitStatusTest : TestBase
public class InboundAchDebitsTest : TestBase
{
[Theory]
[InlineData(DebitStatus.Allowed)]
[InlineData(DebitStatus.Blocked)]
public void Validation_Works(DebitStatus rawValue)
[InlineData(InboundAchDebits.Allowed)]
[InlineData(InboundAchDebits.Blocked)]
public void Validation_Works(InboundAchDebits rawValue)
{
// force implicit conversion because Theory can't do that for us
ApiEnum<string, DebitStatus> value = rawValue;
ApiEnum<string, InboundAchDebits> value = rawValue;
value.Validate();
}

[Fact]
public void InvalidEnumValidationThrows_Works()
{
var value = JsonSerializer.Deserialize<ApiEnum<string, DebitStatus>>(
var value = JsonSerializer.Deserialize<ApiEnum<string, InboundAchDebits>>(
JsonSerializer.SerializeToElement("invalid value"),
ModelBase.SerializerOptions
);
Expand All @@ -182,15 +121,15 @@ public void InvalidEnumValidationThrows_Works()
}

[Theory]
[InlineData(DebitStatus.Allowed)]
[InlineData(DebitStatus.Blocked)]
public void SerializationRoundtrip_Works(DebitStatus rawValue)
[InlineData(InboundAchDebits.Allowed)]
[InlineData(InboundAchDebits.Blocked)]
public void SerializationRoundtrip_Works(InboundAchDebits rawValue)
{
// force implicit conversion because Theory can't do that for us
ApiEnum<string, DebitStatus> value = rawValue;
ApiEnum<string, InboundAchDebits> value = rawValue;

string json = JsonSerializer.Serialize(value, ModelBase.SerializerOptions);
var deserialized = JsonSerializer.Deserialize<ApiEnum<string, DebitStatus>>(
var deserialized = JsonSerializer.Deserialize<ApiEnum<string, InboundAchDebits>>(
json,
ModelBase.SerializerOptions
);
Expand All @@ -201,12 +140,12 @@ public void SerializationRoundtrip_Works(DebitStatus rawValue)
[Fact]
public void InvalidEnumSerializationRoundtrip_Works()
{
var value = JsonSerializer.Deserialize<ApiEnum<string, DebitStatus>>(
var value = JsonSerializer.Deserialize<ApiEnum<string, InboundAchDebits>>(
JsonSerializer.SerializeToElement("invalid value"),
ModelBase.SerializerOptions
);
string json = JsonSerializer.Serialize(value, ModelBase.SerializerOptions);
var deserialized = JsonSerializer.Deserialize<ApiEnum<string, DebitStatus>>(
var deserialized = JsonSerializer.Deserialize<ApiEnum<string, InboundAchDebits>>(
json,
ModelBase.SerializerOptions
);
Expand All @@ -215,84 +154,22 @@ public void InvalidEnumSerializationRoundtrip_Works()
}
}

public class InboundChecksTest : TestBase
{
[Fact]
public void FieldRoundtrip_Works()
{
var model = new InboundChecks { Status = Status.Allowed };

ApiEnum<string, Status> expectedStatus = Status.Allowed;

Assert.Equal(expectedStatus, model.Status);
}

[Fact]
public void SerializationRoundtrip_Works()
{
var model = new InboundChecks { Status = Status.Allowed };

string json = JsonSerializer.Serialize(model, ModelBase.SerializerOptions);
var deserialized = JsonSerializer.Deserialize<InboundChecks>(
json,
ModelBase.SerializerOptions
);

Assert.Equal(model, deserialized);
}

[Fact]
public void FieldRoundtripThroughSerialization_Works()
{
var model = new InboundChecks { Status = Status.Allowed };

string element = JsonSerializer.Serialize(model, ModelBase.SerializerOptions);
var deserialized = JsonSerializer.Deserialize<InboundChecks>(
element,
ModelBase.SerializerOptions
);
Assert.NotNull(deserialized);

ApiEnum<string, Status> expectedStatus = Status.Allowed;

Assert.Equal(expectedStatus, deserialized.Status);
}

[Fact]
public void Validation_Works()
{
var model = new InboundChecks { Status = Status.Allowed };

model.Validate();
}

[Fact]
public void CopyConstructor_Works()
{
var model = new InboundChecks { Status = Status.Allowed };

InboundChecks copied = new(model);

Assert.Equal(model, copied);
}
}

public class StatusTest : TestBase
public class UnregisteredInboundChecksTest : TestBase
{
[Theory]
[InlineData(Status.Allowed)]
[InlineData(Status.CheckTransfersOnly)]
public void Validation_Works(Status rawValue)
[InlineData(UnregisteredInboundChecks.Allowed)]
[InlineData(UnregisteredInboundChecks.Blocked)]
public void Validation_Works(UnregisteredInboundChecks rawValue)
{
// force implicit conversion because Theory can't do that for us
ApiEnum<string, Status> value = rawValue;
ApiEnum<string, UnregisteredInboundChecks> value = rawValue;
value.Validate();
}

[Fact]
public void InvalidEnumValidationThrows_Works()
{
var value = JsonSerializer.Deserialize<ApiEnum<string, Status>>(
var value = JsonSerializer.Deserialize<ApiEnum<string, UnregisteredInboundChecks>>(
JsonSerializer.SerializeToElement("invalid value"),
ModelBase.SerializerOptions
);
Expand All @@ -302,15 +179,15 @@ public void InvalidEnumValidationThrows_Works()
}

[Theory]
[InlineData(Status.Allowed)]
[InlineData(Status.CheckTransfersOnly)]
public void SerializationRoundtrip_Works(Status rawValue)
[InlineData(UnregisteredInboundChecks.Allowed)]
[InlineData(UnregisteredInboundChecks.Blocked)]
public void SerializationRoundtrip_Works(UnregisteredInboundChecks rawValue)
{
// force implicit conversion because Theory can't do that for us
ApiEnum<string, Status> value = rawValue;
ApiEnum<string, UnregisteredInboundChecks> value = rawValue;

string json = JsonSerializer.Serialize(value, ModelBase.SerializerOptions);
var deserialized = JsonSerializer.Deserialize<ApiEnum<string, Status>>(
var deserialized = JsonSerializer.Deserialize<ApiEnum<string, UnregisteredInboundChecks>>(
json,
ModelBase.SerializerOptions
);
Expand All @@ -321,12 +198,12 @@ public void SerializationRoundtrip_Works(Status rawValue)
[Fact]
public void InvalidEnumSerializationRoundtrip_Works()
{
var value = JsonSerializer.Deserialize<ApiEnum<string, Status>>(
var value = JsonSerializer.Deserialize<ApiEnum<string, UnregisteredInboundChecks>>(
JsonSerializer.SerializeToElement("invalid value"),
ModelBase.SerializerOptions
);
string json = JsonSerializer.Serialize(value, ModelBase.SerializerOptions);
var deserialized = JsonSerializer.Deserialize<ApiEnum<string, Status>>(
var deserialized = JsonSerializer.Deserialize<ApiEnum<string, UnregisteredInboundChecks>>(
json,
ModelBase.SerializerOptions
);
Expand Down
Loading
Loading