Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR modernizes R syntax throughout the codebase by adopting newer language features introduced in R 4.1.0+ and contemporary dplyr patterns.
Key Changes:
- Replaced
function(x)with anonymous function shorthand\(x)syntax - Modernized dplyr code from
group_by() %>% tally() %>% ungroup()tosummarise(.by = ...)pattern - Replaced
isFALSE()with!operator for logical negation - Changed
ifelse()toif-elsefor scalar conditional assignments - Updated GitHub Actions workflow for code coverage with better configuration
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| R/utils.R | Updated error handler to use anonymous function shorthand \(e) |
| R/ggpiestats.R | Changed isFALSE(paired) to !paired in condition |
| R/ggpiestats-ggbarstats-helpers.R | Modernized .cat_counter to use .by parameter; updated .chisq_test_safe with new syntax and parameter handling |
| R/gghistostats.R | Updated labels parameter to use anonymous function shorthand |
| R/ggbetweenstats-helpers.R | Changed .f_switch from vectorized ifelse() to scalar if-else |
| R/ggbarstats.R | Changed isFALSE(paired) to !paired in condition |
| R/extract-stats.R | Converted multiple function definitions to anonymous function shorthand |
| .github/workflows/test-coverage.yaml | Enhanced workflow with explicit permissions, updated runner, improved coverage reporting, and artifact upload |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.