You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We have errors with the test svg : they are differents from the output svg and it fails the test. In this pull request, We changed how the axis name is displayed in order to fix #695. We could use some help with how to interpret and fix the test errors.
Can you demonstrate that you solved the problem ? Like by posting an example before and after ? (here or on the issue)
For the tests, you can run them on your own computer with testthat::test_local(). The 5 failing tests are all snapshot tests, i.e. tests that register a base image and then check that a code does not accidentally modify the output. This is normal here because your change does modify the output ! You can review and accept those changes locally with testthat::snapshot_review(). Do not blindly accept all changes : they actually help you check that only the needed parts have changed. Once you accepted a new snapshot you can commit it to this pull request as you would do for any other part of the code.
Here is a demonstration of the problem solved :
Before (ggstatplot main branch)
After (this branch, see the effectif properly displayed at the bottom of the image)
You can achieve the same results by cloning our branch and lauching the fixed ggstatbetweenplot function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correction of the issue 695