-
Notifications
You must be signed in to change notification settings - Fork 72
changed Makefile.test, updated submodule for arduino-core-tests #336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Frederikwag, your commit message check fails. Please have a look here and then here.
Please let me know if you have questions.
Regarding the failing HIL checks we can see what's wrong once the commit checks are succeeding.
The fqbn vendor renaming and the ports are specific to @Frederikwag local setup. |
Yes, it is. This is just a test command that we have validated and will be used in HIL in the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revise based on the review comments.
I remember we also had some test failures (invalid pins) when running gpio, not found in the description
# 1 boards | ||
|
||
make FQBN=arduino-git:xmc:XMC4700_Relax_Kit PORT=/dev/ttyACM1 UNITY_PATH=\Unity test_digitalio_single monitor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for gpio, we do need a test_config.h for pin definition right? Should it be added to the PR?
tests/arduino-core-tests
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
correct added. good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can ask Julian to help with commit msg ;)
_build/ | ||
|
||
echo "libraries/SPI/src/SPI.cpp" >> .gitignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why adding echo command in .gitignore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because everything what is related to SPI is a different branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check: https://www.geeksforgeeks.org/what-is-git-ignore-and-how-to-use-it/
and: https://www.geeksforgeeks.org/echo-command-in-linux-with-examples/
to understand real reason why you want to use echo and add the path in .gitignore and why I ask you to remove this code.
tests/arduino-core-tests
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, this time the submodule points to a unknow hash tag... please double check
tests/test_config.h
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot to mention that it would be great to add the name of the board used here. Because xmc has a lot of different targets
Signed-off-by: Frederikwag <[email protected]>
Signed-off-by: Frederikwag <[email protected]>
Signed-off-by: Frederikwag <[email protected]>
Signed-off-by: Frederikwag <[email protected]>
Signed-off-by: Frederikwag <[email protected]>
697dc31
to
c4f7da8
Compare
By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---
CONTRIBUTING.md also tells you what to expect in the PR process.
Description
The submodule "Arduino-Core-Test" in the repo "XMC-for-Arduino" linked to an older version. The version of "Arduino-Core-Test" was updated to the newest one, the different tests were executed and it was documented which tests are also working. The files where adapted accordingly.
Related Issue
It's not an issue, but tasks that still need to be done:
--> Expected Delay: 500000 microseconds; Actual Delay: 506483 microseconds; Tolerance: 100 microseconds (result: values not within delta 100)
Context
Quiet similar to previous push (added-spi), but tried to reduce amount of changes. Therefore checked code again.