Skip to content

Desmakers 4505 #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 15, 2025
Merged

Desmakers 4505 #339

merged 2 commits into from
Apr 15, 2025

Conversation

OlafFilies
Copy link
Member

By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---

This pull request includes changes to the OneWire library to improve functionality and some formatting adjustments in the OneWireConf.h file.

Functional improvements:

Formatting adjustments:

@LinjingZhang LinjingZhang self-requested a review April 14, 2025 15:24
Copy link
Collaborator

@LinjingZhang LinjingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for fixing!

@jaenrig-ifx
Copy link
Member

Not much I can judge. I am not familiar with the onewire lib👍
Ideally this would be enabled and maintained directly in the official lib?

@LinjingZhang
Copy link
Collaborator

LinjingZhang commented Apr 15, 2025

Not much I can judge. I am not familiar with the onewire lib👍 Ideally this would be enabled and maintained directly in the official lib?

well It's gonna open up another Pandora's box... 🤣
Inside the official lib these function are correctly returned

@LinjingZhang LinjingZhang merged commit 8a7dbea into master Apr 15, 2025
24 of 26 checks passed
@LinjingZhang LinjingZhang deleted the DESMAKERS-4505 branch April 15, 2025 08:31
@jaenrig-ifx
Copy link
Member

Not much I can judge. I am not familiar with the onewire lib👍 Ideally this would be enabled and maintained directly in the official lib?

well It's gonna open up another Pandora's box... 🤣 Inside the official lib these function are correctly returned

Yes. I don´t want to open it no. But maybe in the 4.x better than bringing this into the core, it can be added against the official library. And maintain it from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants