Skip to content

variants/XMC1400: Add SPI pin definitions. #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2025
Merged

Conversation

ederjc
Copy link
Member

@ederjc ederjc commented Apr 15, 2025

By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---

CONTRIBUTING.md also tells you what to expect in the PR process.

Description
This pull request includes changes to the pins_arduino.h files for the XMC1400_Arduino_Kit and XMC1400_XMC2GO variants. The changes involve adding external variable declarations for SPI pin assignments.

Related Issue
MHB and other libs using SPI not compiling on XMC1400-based boards.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (2)
  • variants/XMC1400/config/XMC1400_Arduino_Kit/pins_arduino.h: Language not supported
  • variants/XMC1400/config/XMC1400_XMC2GO/pins_arduino.h: Language not supported

@LinjingZhang
Copy link
Collaborator

Well, I didn't make this change before because I was not sure that using extern was the best way to do it. Refer to arduinoCore-AVR: https://github.com/arduino/ArduinoCore-avr/blob/master/variants/robot_control/pins_arduino.h#L62C1-L65C41
But if it's for a compile test pass - I don't see a problem with merge to master.

@ederjc ederjc merged commit ff53247 into master Apr 15, 2025
26 checks passed
@ederjc ederjc deleted the bugfix/add-spi-pins branch April 15, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants